Improved distortion api #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `distort_points` and `undistort_points` now return arrays of shape `(N, 2)`
|
Merged main into this branch and resolved merge conflicts, but did not yet remove the duplicate tests! |
|
Are you working on that or should I? |
|
Should be ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add crop_parameter to
undistort_imagestyle: make
point_to_raysprivatefeat: add overloads to accept
list[Point]indistort_imageandundistort_imagefeat: reshape
image_pointsto accept a wider range of input pointsfeat: reshape points array to
Nx2before returning ittest: add image undistortion and distortion tests
type: type inputs and outputs as
FloatArraywhere applicableBREAKING CHANGE:
distort_pointsandundistort_pointsnow return arrays of shape(N, 2)