[ZIP 325] Add note about Zashi's poor choice of a private-use subject string #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Signed-off-by: Daira-Emma Hopwood <[email protected]>
…as a private-use subject. Signed-off-by: Daira-Emma Hopwood <[email protected]>
daira
commented
Mar 4, 2025
Comment on lines
+81
to
+89
| - $m_{\mathsf{metadata}} / 325' / \mathsf{coinType}' / \mathsf{account}'$ - Account Metadata Key | ||
| - $\ldots / 0'$ - Account-level Inherent Metadata Key | ||
| - $\ldots / \ldots$ - (Reserved for future updates to this ZIP) | ||
| - $\ldots / (\mathtt{0x7FFFFFFF}', \mathsf{PrivateUseSubject})$ - Private-use Inherent Metadata Key | ||
| - $\ldots / 1'$ - Account-level External Metadata Key | ||
| - $\ldots / (0', \mathsf{FVKTypedItem})$ - Imported UFVK Metadata Key | ||
| - $\ldots / \ldots$ - (Reserved for future updates to this ZIP) | ||
| - $\ldots / (\mathtt{0x7FFFFFFF}', \mathsf{PrivateUseSubject})$ - Private-use External Metadata Key | ||
| - $\ldots / \ldots$ - (Reserved for future updates to this ZIP) |
There was a problem hiding this comment.
MultiMarkdown is picky about the number of spaces used to indent nested lists: it must be at least 3.
daira
commented
Mar 4, 2025
| @@ -171,16 +171,21 @@ valid hardened child index) within its key tree for this purpose. | |||
| most 252 bytes that identifies the desired private-use context. | |||
| - Return $\mathsf{CKDreg}(K, \mathtt{0x7FFFFFFF}, \mathsf{PrivateUseSubject})$ | |||
|
|
|||
| :::warning | |||
| <div class=warning></div> | |||
There was a problem hiding this comment.
This affects the following paragraph. At some point I'll fix it to support multi-paragraph notes/warnings, but for now this was the only way I could get the CSS to work.
str4d
reviewed
Mar 4, 2025
|
|
||
| <div class="note"></div> | ||
|
|
||
| Zashi uses the string $\texttt{“metadata”}$ for $\mathsf{PrivateUseSubject}$. |
There was a problem hiding this comment.
Suggested change
| Zashi uses the string $\texttt{“metadata”}$ for $\mathsf{PrivateUseSubject}$. | |
| Zashi uses the string $\texttt{“metadata”}$ for one of its $\mathsf{PrivateUseSubject}$ use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the rendering of notes and warnings for Markdown ZIPs.