Fix #31 #32
Merged
Fix #31 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the use of the `std::make_tuple` function with an explicit call to the c++ tuple constructor. The old version did relay the implementation defined argument evaluation order of function calls. This broke on g++. See for example this question for more details: https://stackoverflow.com/questions/14056000/how-to-avoid-undefined-execution-order-for-the-constructors-when-using-stdmake
ma2bd
approved these changes
Mar 28, 2023
| @@ -610,8 +610,13 @@ struct Deserializable<std::tuple<Types...>> { | |||
| template <typename Deserializer> | |||
| static std::tuple<Types...> deserialize(Deserializer &deserializer) { | |||
| // Visit each of the type components. | |||
| return std::make_tuple( | |||
| Deserializable<Types>::deserialize(deserializer)...); | |||
| // do not use `std::make_tuple` here | |||
ma2bd
approved these changes
Mar 28, 2023
|
Thanks for putting out a release containing this fix in such a timely manner ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit replaces the use of the
std::make_tuplefunction with an explicit call to the c++ tuple constructor. The old version did relay the implementation defined argument evaluation order of function calls. This broke on g++. See for example this question for more details: https://stackoverflow.com/questions/14056000/how-to-avoid-undefined-execution-order-for-the-constructors-when-using-stdmakeTest Plan
I've tested locally that this fixes the reported issue. Otherwise it's hard to test for that as this relays on implementation specified behaviour.