Fix Dart list equality #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best I can tell the test failures are unrelated to my changes. Looks like a Deno failure perhaps? |
|
Thanks for the PR. Hoping to have a look soon |
|
Any luck with deno? |
ma2bd
approved these changes
Jun 5, 2024
|
@jerel This was released with |
|
@ma2bd thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the case of
Option<Vec<_>>the generated Dart was not usinglistEquals(field, other.field)to check for equality like it does forVec<_>because the match statement was checkingOptionand falling through to the default case offield == other.field.Test Plan
The test_utils.rs data structures didn't include a case where a vec was optional. This PR adds a field to demonstrate that case. This PR also includes test code which verifies that the generated Dart code is now correct.