Add a config field that controls package manifest generation #66
Conversation
|
It's strange that the Golang test is failing when I’ve only made minor changes on the Dart side. Any suggestions, @ma2bd? |
temeddix
changed the title
pubspec.yaml if it already existspubspec.yaml if it already exists
|
Hey @temeddix, Thanks for the kind words. Rinf looks very interresting by the way. I'm going to look into the issue with golang in CI. About this PR: If I'm reading the code correctly, this would make |
|
Sure, I applied things you've mentioned. I discovered that I had to ask a few more questions:
I'm open to any changes, so please let me know if anything needs improvement. I've already applied these changes to PR to demonstrate. |
This reverts commit 09eeed8.
temeddix
changed the title
pubspec.yaml if it already exists
serde-generate-bin/src/main.rs
Outdated
| /// Avoid creating a package spec file defining dependencies for the chosen language. | ||
| /// Takes effect only for languages that have a package manifest format. | ||
| #[structopt(long)] | ||
| no_package_manifest: bool, |
There was a problem hiding this comment.
nit: This is fine but I'd suggest --skip-package-manifest here so that we can use the name skip_package_manifest consistently in the whole code, with a standard default value false.
There was a problem hiding this comment.
Done :) I realized that the default value for a clap bool field is false.
|
@temeddix Released in serde-generate v0.29.0 and serde-generate-bin v0.5.0 |
Summary
Hi all,
First off, thanks for all the hard work you do maintaining this repository—it truly is a great work.
In this PR, I've updated the
CodeGenerator.outputmethod so that it ignores an existingpubspec.yaml, preventing it from being overwritten when usingserde-generatefor Dart code. I'm open to any modifications or suggestions, and I'll respond as quickly as possible to any feedback. This change is intended for use at Rinf.Looking forward to your thoughts!
Test Plan
Empty