Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dart linter happy #67

Merged
merged 4 commits into from
Mar 3, 2025
Merged

Conversation

temeddix
Copy link
Contributor

@temeddix temeddix commented Mar 2, 2025

Summary

When trying to use serde-generate in a real-life scenario, the Dart linter warned about specific rule violations. This PR addresses those warnings.

  • unused_import
    image
    • Dart docs
    • package:meta or package:tuple might be unused in some scenarios.
  • use_string_in_part_of_directives
    image
    image

Test Plan

If the CI passes, everything should be fine.

@temeddix temeddix requested a review from ma2bd as a code owner March 2, 2025 07:23
@temeddix temeddix changed the title Satisfy Dart linter Make Dart linter happy Mar 2, 2025
Copy link
Contributor

@ma2bd ma2bd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase after #68 is landed for the CI

@ma2bd ma2bd merged commit a1cc9c1 into zefchain:main Mar 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants