Retry rename on lock induced failures (re-fix)

Unfortunately go-gitea#16435 asserts the wrong error and should use os.LinkError not os.PathError. Fix go-gitea#16439 Signed-off-by: Andrew Thornton <[email protected]>
zeripath · Jul 16, 2021 · fc01ed8 · fc01ed8
1 parent 95f4004
commit fc01ed8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/modules/util/remove.go b/modules/util/remove.go
@@ -64,7 +64,7 @@ func Rename(oldpath, newpath string) error {
 		if err == nil {
 			break
 		}
-		unwrapped := err.(*os.PathError).Err
+		unwrapped := err.(*os.LinkError).Err
 		if unwrapped == syscall.EBUSY || unwrapped == syscall.ENOTEMPTY || unwrapped == syscall.EPERM || unwrapped == syscall.EMFILE || unwrapped == syscall.ENFILE {
 			// try again
 			<-time.After(100 * time.Millisecond)