Skip to content

Commit

Permalink
Merge pull request #288 from guersam/simplify-transformto
Browse files Browse the repository at this point in the history
Remove unnecessary type param from `transformTo`
  • Loading branch information
vigoo authored Feb 19, 2025
2 parents 41d11f3 + 8840c02 commit 8173776
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion zio-parser/shared/src/main/scala/zio/parser/Syntax.scala
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class Syntax[+Err, -In, +Out, Value] private (
*
* This can be used to define separate syntaxes for subtypes, that can be later combined.
*/
final def transformTo[Err2 >: Err, Value2, Result2](
final def transformTo[Err2 >: Err, Value2](
to: Value => Value2,
from: PartialFunction[Value2, Value],
failure: Err2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@ object ExpressionExample extends ZIOSpecDefault {
.filter[String, Char](_.isDigit, "not a digit")
.repeat
.string
.transformTo[String, Expr, Expr](
.transformTo[String, Expr](
s => Const(s.toInt),
{ case (n: Const) => n.value.toString },
"Not a constant"
) ?? "constant"
val operator: Syntax[String, Char, Char, OpType] =
(Syntax.charIn('+').transformTo[String, OpType, OpType](_ => Add, { case Add => '+' }, "Not +") <>
Syntax.charIn('-').transformTo[String, OpType, OpType](_ => Sub, { case Sub => '-' }, "Not -")) ?? "operator"
(Syntax.charIn('+').transformTo[String, OpType](_ => Add, { case Add => '+' }, "Not +") <>
Syntax.charIn('-').transformTo[String, OpType](_ => Sub, { case Sub => '-' }, "Not -")) ?? "operator"
val lparen: Syntax[String, Char, Char, Unit] = Syntax.char('(')
val rparen: Syntax[String, Char, Char, Unit] = Syntax.char(')')

lazy val subExpr: Syntax[String, Char, Char, Expr] =
(expr ~ operator ~ expr)
.transformTo[String, Expr, Expr](
.transformTo[String, Expr](
{ case (a, op, b) =>
Op(op, a, b)
},
Expand Down

0 comments on commit 8173776

Please sign in to comment.