Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote code execution vulnerability #238

Closed
deenrookie opened this issue Jun 2, 2020 · 1 comment
Closed

Remote code execution vulnerability #238

deenrookie opened this issue Jun 2, 2020 · 1 comment

Comments

@deenrookie
Copy link

Hi, this is Tencent Xcheck team. Our code safety check tool Xcheck has found several unserialize vulnerabilities in this project(v4, v5, v6). It leads to remote code execution. Here are the details.

v6

  1. app/admin/controller/api/Update.php
    line: 46 $this->rules = unserialize($this->request->post('rules', 'a:0:{}', ''));
    line: 47 $this->ignore = unserialize($this->request->post('ignore', 'a:0:{}', ''));

v6 v5 v4
2. app/wechat/controller/api/Push.php
line: 102 $this->receive = $this->toLower(unserialize($this->request->post('receive', '', null)));

Prevent from abusing of this vulnerability, we don't provide proof of concept. We hope to repair it as soon as possible.

From Xcheck Team

zoujingli added a commit that referenced this issue Jun 15, 2020
zoujingli added a commit that referenced this issue Jun 16, 2020
zoujingli added a commit that referenced this issue Jun 16, 2020
@zoujingli
Copy link
Owner

ThinkAdmin V6 接口的序列化数据全部改成了 JSON
更新方式:
composer update 更新 vendor 中的 think-library
php think xadmin:install admin 更新 admin 模块
php think xadmin:install wechat 更新 wechat 模块

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@zoujingli @deenrookie and others