Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Broken-looking context menus. #2365

Closed
zingmars opened this issue Apr 20, 2018 · 9 comments · Fixed by #2910
Closed

[Android] Broken-looking context menus. #2365

zingmars opened this issue Apr 20, 2018 · 9 comments · Fixed by #2910
Labels
a-Android bug upstream: RN Issues related to an issue in React Native

Comments

@zingmars
Copy link

zingmars commented Apr 20, 2018 •
edited
Loading

Context menus in some places seem to be very broken looking.

screenshot-menu-1
screenshot-menu-2

This is on Android 8.0, OnePlus A3003. App version v12.3.83 from GitHub Releases.
@borisyankov
Copy link
Contributor

Thanks for reporting this. I thought we fixed that, I guess not.

@pulkonet
Copy link
Collaborator

@borisyankov This would only be fixed via expo and couldn't be handled on our part. Expo's component do not support OnePlus Slate font very well and that's the only reason why this and other expo components used look broken on OnePlus and Oppo phones.

A little suggestion @zingmars, if you wanna overcome this - Change your font to Roboto (it is available in settings>font). That is the only fix until expo updates their components and provide support for OnePlus slate font.

@zingmars
Copy link
Author

Yup, the menus show up fine with Roboto. Is there an issue about this in expo's vcs that I can track?

@pulkonet
Copy link
Collaborator

@zingmars Here it is. It is not for action sheet but similar as this issue exists in all of the expo components.

@gnprice gnprice mentioned this issue May 3, 2018
Open
@gnprice
Copy link
Member

gnprice commented May 3, 2018

Thanks again @zingmars for this report! On our side, I think the fix for this will end up being for us to ship one font and use it consistently: a project I've just filed as #2447.

jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Aug 22, 2018
@jainkuniya
action-sheet: Update react-native-action-sheet to ^1.1.0.
e768522 
This fixes the long pending issue of text in options being cut on One
Plus and Oppo phones.

Fix: zulip#2365
@jainkuniya
Copy link
Member

@zulipbot claim

@jainkuniya jainkuniya mentioned this issue Aug 22, 2018
Merged
jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Aug 31, 2018
@jainkuniya
action-sheet: Update react-native-action-sheet to ^1.1.0.
a082bca 
This fixes the long pending issue of text in options being cut on One
Plus and Oppo phones.

Also the styling is now material design and is way better on Android.

Fix: zulip#2365
jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Sep 10, 2018
@jainkuniya
action-sheet: Update react-native-action-sheet to ^1.1.0.
10c086a 
This fixes the long pending issue of text in options being cut on One
Plus and Oppo phones.

Also the styling is now material design and is way better on Android.

Fix: zulip#2365
@gnprice gnprice added the upstream: RN Issues related to an issue in React Native label Oct 3, 2018
@gnprice
Copy link
Member

gnprice commented Oct 3, 2018

The root issue here appears to be facebook/react-native#15114 .

Still not clear to me if this is the fault of RN, or of those fonts, or what.

gnprice pushed a commit to jainkuniya/zulip-mobile that referenced this issue Oct 3, 2018
@jainkuniya @gnprice
action-sheet: Update to v1.1.0 of Expo's action-sheet library.
08bd6c9 
This is the library that provides an Android equivalent for RN
upstream's ActionSheetIOS; v1.1.0 comes with a bunch of changes to
the layout, intended to make it conform to Material Design.

The new layout isn't great, but it does happen to fix the long-pending
issue of text in options being cut off on One Plus and Oppo phones.
(Perhaps because it no longer makes the text bold.)  Screenshots
in zulip#2910.

Fixes zulip#2365.
@gnprice
Copy link
Member

gnprice commented Jun 21, 2019

Small update FFR, since we just ran into the same underlying upstream bug in #3533:

It looks like the key thing that triggers the bug is setting fontWeight. E.g., trying to make text bold.

In particular:

@gnprice gnprice mentioned this issue Jun 21, 2019
Merged
@ishammahajan
Copy link
Collaborator

Some speculation, this might be due to the text box not recalculating its size based on the changes fontWeight.

@gnprice gnprice mentioned this issue Mar 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-Android bug upstream: RN Issues related to an issue in React Native
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

action-sheet: Update react-native-action-sheet to ^1.1.0. jainkuniya/zulip-mobile
6 participants
@gnprice @borisyankov @zingmars @jainkuniya @pulkonet @ishammahajan