Sample app fixes #527
Merged
Sample app fixes #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two commits that addresses updates in the sample apps (both Swift and Obj-c versions):
Updating obj-c sample app and fixing indents (2b9861c): Minor updates to the objective-c sample app. This includes:
Fixing applyRectOfInterest method (486c7d4): When working with different screen sizes, the current method to determine the rect of interest didn't calculate the area correctly. Examples of this is when you want to have a scanner on a modal view or on another screen size such as an iPad. It also reduces some of the boiler plate around those calculations, relying on Apple's APIs to leverage the work around calculating the value.