-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Xcode 14.3 which supports only iOS 11.0+ #575
Conversation
d0ae656
to
ad157f5
Compare
ad157f5
to
57f0bae
Compare
@benjohnde & @tknoelle As far as I understood you two can approve and merge a pullrequest. It would be very cool if you could review it, merge it back and release a new version which can be used with xCode 14.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the changes is breaking target "OS X". See other comments
* Set MACOSX_DEPLOYMENT_TARGET=10.15 to gain access to AVCaptureDeviceDiscoverySession, which replaces deprecated AVCaptureDevice devicesWithMediaType: * Change README to reflect the new minimum OS levels
The osx target and its unit tests are passing, now that I updated the deployment target to 10.15. Also I updated the README to indicate the new base level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate your work :)
I added some new comments in Pullrequest.
@kenstir Are you able to make the change to the "s.ios.deployment_target" and "s.osx.deployment_target" values in the "ZXingObjC.podspec" file as requested by @KBEMobisys in the pull request here? |
I will do it! Sorry for letting this drag on. |
in README, podspec, and BarcodeScanner sample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self check: pass
All the PR comments are addressed and I'm ready for a rereview.
Hey, these changes are exactly what I'm waiting for! When can I expect to bump deployment target to keep Xcode 14 happy? |
@adil-hussain-84 Could you review the pull request again? And are you able to merge it or who can do this?? |
@KBEMobisys: Sadly I don't have write access 🙁 I'm hoping one of the individuals listed in the Kudos section of the project's README file (@cwalcott and/or @neacao perhaps) can review the pull request and merge it in 🙏 |
@benjohnde @tknoelle You are members of zxingify. Could you review and merge this PR? We would love to see a new release with this change, so zxingify is compatible to Xcode 14.3 and above. |
Sry for the delay, I can merge it tomorrow and also prepare a cocoapods release. |
Thank you so much @benjohnde for merging in the pull request and performing the release 🙏 We were starting to fear the worst that we'd have to fork this repository and maintain the fork. |
Summary
Update code to build and examples to run under Xcode 14.3.
Detailed Changes
with AVCaptureDeviceDiscoverySession