Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode 14.3 which supports only iOS 11.0+ #575

Merged
merged 7 commits into from
Oct 5, 2023

Conversation

kenstir
Copy link
Contributor

@kenstir kenstir commented Apr 8, 2023

Summary

Update code to build and examples to run under Xcode 14.3.

Detailed Changes

  • Replace deprecated function AVCaptureDevice devicesWithMediaType:
    with AVCaptureDeviceDiscoverySession
  • Update macOS target to 10.15 (from 10.8) to gain access to AVCaptureDeviceDiscoverySession
  • Update iOS target to 11.0 (from 8.0) to compile with Xcode 14.3
  • Change README to reflect the new minimum OS levels
  • Change and test BarcodeScanner and BarcodeScannerSwift examples

@kenstir kenstir force-pushed the kenstir/fix-xcode-14.3 branch from d0ae656 to ad157f5 Compare April 9, 2023 00:37
@kenstir kenstir force-pushed the kenstir/fix-xcode-14.3 branch from ad157f5 to 57f0bae Compare April 9, 2023 00:47
@KBEMobisys
Copy link

KBEMobisys commented Jul 24, 2023

@benjohnde & @tknoelle As far as I understood you two can approve and merge a pullrequest. It would be very cool if you could review it, merge it back and release a new version which can be used with xCode 14.x.

Copy link

@KBEMobisys KBEMobisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes is breaking target "OS X". See other comments

* Set MACOSX_DEPLOYMENT_TARGET=10.15 to gain access to
  AVCaptureDeviceDiscoverySession, which replaces deprecated
  AVCaptureDevice devicesWithMediaType:
* Change README to reflect the new minimum OS levels
@kenstir
Copy link
Contributor Author

kenstir commented Aug 1, 2023

One of the changes is breaking target "OS X". See other comments

The osx target and its unit tests are passing, now that I updated the deployment target to 10.15. Also I updated the README to indicate the new base level.

Copy link

@KBEMobisys KBEMobisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your work :)

I added some new comments in Pullrequest.

@adil-hussain-84
Copy link
Contributor

@kenstir Are you able to make the change to the "s.ios.deployment_target" and "s.osx.deployment_target" values in the "ZXingObjC.podspec" file as requested by @KBEMobisys in the pull request here?

@kenstir
Copy link
Contributor Author

kenstir commented Sep 7, 2023

@kenstir Are you able to make the change to the "s.ios.deployment_target" and "s.osx.deployment_target" values in the "ZXingObjC.podspec" file as requested by @KBEMobisys in the pull request here?

I will do it! Sorry for letting this drag on.

in README, podspec, and BarcodeScanner sample
Copy link
Contributor Author

@kenstir kenstir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self check: pass

All the PR comments are addressed and I'm ready for a rereview.

@ale-gen
Copy link

ale-gen commented Sep 29, 2023

Hey, these changes are exactly what I'm waiting for! When can I expect to bump deployment target to keep Xcode 14 happy?

@KBEMobisys
Copy link

@adil-hussain-84 Could you review the pull request again? And are you able to merge it or who can do this??
Would be great to finalize this soon :)

@adil-hussain-84
Copy link
Contributor

adil-hussain-84 commented Oct 2, 2023

@KBEMobisys: Sadly I don't have write access 🙁 I'm hoping one of the individuals listed in the Kudos section of the project's README file (@cwalcott and/or @neacao perhaps) can review the pull request and merge it in 🙏

@KBEMobisys
Copy link

@benjohnde @tknoelle You are members of zxingify. Could you review and merge this PR?

We would love to see a new release with this change, so zxingify is compatible to Xcode 14.3 and above.

@benjohnde
Copy link
Member

@benjohnde @tknoelle You are members of zxingify. Could you review and merge this PR?

We would love to see a new release with this change, so zxingify is compatible to Xcode 14.3 and above.

Sry for the delay, I can merge it tomorrow and also prepare a cocoapods release.

@benjohnde benjohnde merged commit 7f05df1 into zxingify:master Oct 5, 2023
@adil-hussain-84
Copy link
Contributor

Thank you so much @benjohnde for merging in the pull request and performing the release 🙏 We were starting to fear the worst that we'd have to fork this repository and maintain the fork.

@kenstir kenstir deleted the kenstir/fix-xcode-14.3 branch January 6, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants