Refactor API Endpoints into Services Folder #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dosubot
bot
added
size:XL
|
@bekossy can you have a look at the comments please |
dosubot
bot
added
size:XXL
dosubot
bot
added
size:XL
…' into refactor/-move-api-to-service-dir_v2
….com/Agenta-AI/agenta into refactor/-move-api-to-service-dir_v2
…Refactor-API-Endpoints-into-Services-Folder
aakrem
requested changes
Jun 7, 2024
There was a problem hiding this comment.
@bekossy Thanks for the PR
I suggest adding a folder that contains all api files at it's not clear what exactly service/index.tx file
Example
services/deployment/api/index.ts
services/evaluations/api/index.ts
we can keep services/api.ts for now for shared api methods
|
@bekossy thanks a lot for the PR! |
aakrem
deleted the
issue-1622/-Refactor-API-Endpoints-into-Services-Folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1622
To QA this please:
Related PR in commons
Pull Request: #51