Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor API Endpoints into Services Folder #1623

Merged
merged 26 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
1bda818
refactored api endpoints and cleanup
bekossy May 7, 2024
e929268
moved api to service dir
bekossy May 8, 2024
6b40212
cleanup
bekossy May 8, 2024
ccbdcd2
fixed dynamic service path
bekossy May 8, 2024
a6ce210
refactor: modify apis variable to ensure consistent naming convention
bekossy May 14, 2024
c173bea
fixed dynamic service imports
bekossy May 15, 2024
49ed7df
Merge branch 'main' into issue-1622/-Refactor-API-Endpoints-into-Serv…
bekossy May 17, 2024
fd2201f
fixed prettier
bekossy May 17, 2024
aa706dc
convert all fetch functions to use axios
bekossy May 20, 2024
96ae22b
Merge branch 'main' into issue-1622/-Refactor-API-Endpoints-into-Serv…
bekossy May 20, 2024
ae4beaa
Merge branch 'main' into issue-1622/-Refactor-API-Endpoints-into-Serv…
bekossy May 31, 2024
becff5c
Merge branch 'main' into issue-1622/-Refactor-API-Endpoints-into-Serv…
bekossy Jun 4, 2024
b51809c
Merge branch 'main' into refactor/-move-api-to-service-dir_v2
bekossy Jun 4, 2024
e409ea6
removed service folder in lib dir
bekossy Jun 4, 2024
a17fc60
Merge branch 'issue-1622/-Refactor-API-Endpoints-into-Services-Folder…
bekossy Jun 4, 2024
d27e7d9
revert previous changes
bekossy Jun 4, 2024
22e7481
revert changes
bekossy Jun 4, 2024
b0941a2
Merge branch 'refactor/-move-api-to-service-dir_v2' of https://github…
bekossy Jun 4, 2024
90ead42
revert changes
bekossy Jun 4, 2024
9c15b1d
Merge branch 'refactor/-move-api-to-service-dir_v2' into issue-1622/-…
bekossy Jun 4, 2024
622a6ac
replaced fetch method with axios
bekossy Jun 4, 2024
c141eed
hot fix
bekossy Jun 4, 2024
efcb242
hot fix
bekossy Jun 4, 2024
305e561
Merge branch 'main' into issue-1622/-Refactor-API-Endpoints-into-Serv…
bekossy Jun 7, 2024
3ebcf6c
refactor(frontend): improved api services file structure
bekossy Jun 7, 2024
c5de6f7
fixed dynamically imported service file path
bekossy Jun 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions agenta-web/src/components/AppSelector/AppCard.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import {Modal, Card, Avatar} from "antd"
import {DeleteOutlined} from "@ant-design/icons"
import {removeApp} from "@/lib/services/api"
import {removeApp} from "@/services/api"
import {useState} from "react"
import Link from "next/link"
import {renameVariablesCapitalizeAll} from "@/lib/helpers/utils"
import {createUseStyles} from "react-jss"
import {getGradientFromStr} from "@/lib/helpers/colors"
import {ListAppsItem} from "@/lib/Types"
import {useAppsData} from "@/contexts/app.context"

Expand Down
7 changes: 1 addition & 6 deletions agenta-web/src/components/AppSelector/AppSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,7 @@ import {useAppTheme} from "../Layout/ThemeContextProvider"
import TipsAndFeatures from "./TipsAndFeatures"
import Welcome from "./Welcome"
import {isAppNameInputValid, isDemo, redirectIfNoLLMKeys} from "@/lib/helpers/utils"
import {
createAndStartTemplate,
getTemplates,
removeApp,
waitForAppToStart,
} from "@/lib/services/api"
import {createAndStartTemplate, getTemplates, removeApp, waitForAppToStart} from "@/services/api"
import AddNewAppModal from "./modals/AddNewAppModal"
import AddAppFromTemplatedModal from "./modals/AddAppFromTemplateModal"
import MaxAppModal from "./modals/MaxAppModal"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ import {
} from "antd"
import {
updateEvaluationScenario,
callVariant,
fetchEvaluationResults,
updateEvaluation,
} from "@/lib/services/api"
} from "@/services/human-evaluations"
import {callVariant} from "@/services/api"
import {useVariants} from "@/lib/hooks/useVariant"
import {useRouter} from "next/router"
import {EvaluationFlow} from "@/lib/enums"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {useState, useEffect, useCallback, useMemo} from "react"
import {useState, useEffect, useCallback} from "react"
import type {ColumnType} from "antd/es/table"
import {CaretRightOutlined} from "@ant-design/icons"
import {
Expand All @@ -15,7 +15,8 @@ import {
Typography,
message,
} from "antd"
import {updateEvaluationScenario, callVariant, updateEvaluation} from "@/lib/services/api"
import {callVariant} from "@/services/api"
import {updateEvaluationScenario, updateEvaluation} from "@/services/human-evaluations"
import {useVariants} from "@/lib/hooks/useVariant"
import {useRouter} from "next/router"
import {EvaluationFlow} from "@/lib/enums"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import {deleteEvaluations, fetchEvaluationResults, loadEvaluations} from "@/lib/services/api"
import {
deleteEvaluations,
fetchEvaluationResults,
loadEvaluations,
} from "@/services/human-evaluations"
import {Button, Spin, Statistic, Table, Typography} from "antd"
import {useRouter} from "next/router"
import {useEffect, useState} from "react"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {deleteEvaluations, fetchData} from "@/lib/services/api"
import {fetchData} from "@/services/api"
import {deleteEvaluations} from "@/services/human-evaluations"
import {Button, Spin, Statistic, Table, Typography} from "antd"
import {useRouter} from "next/router"
import {useEffect, useState} from "react"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, {useEffect, useState} from "react"
import {GenericObject, JSSTheme, Parameter, Variant} from "@/lib/Types"
import {createNewEvaluation, fetchVariants, useLoadTestsetsList} from "@/lib/services/api"
import {fetchVariants} from "@/services/api"
import {createNewEvaluation} from "@/services/human-evaluations"
import {isDemo} from "@/lib/helpers/utils"
import {Button, Col, Dropdown, MenuProps, Modal, ModalProps, Row, Spin, message} from "antd"
import {getErrorMessage} from "@/lib/helpers/errorHandler"
Expand All @@ -11,9 +12,9 @@ import {getAllVariantParameters} from "@/lib/helpers/variantHelper"
import {useRouter} from "next/router"
import {useAppTheme} from "../Layout/ThemeContextProvider"
import {createUseStyles} from "react-jss"
import {getApikeys} from "@/lib/helpers/llmProviders"
import EvaluationErrorModal from "../Evaluations/EvaluationErrorModal"
import {dynamicComponent} from "@/lib/helpers/dynamic"
import {useLoadTestsetsList} from "@/services/testsets"

type StyleProps = {
themeMode: "dark" | "light"
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/components/Layout/Layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {createUseStyles} from "react-jss"
import NoSSRWrapper from "../NoSSRWrapper/NoSSRWrapper"
import {ErrorBoundary} from "react-error-boundary"
import ErrorFallback from "./ErrorFallback"
import {fetchData} from "@/lib/services/api"
import {fetchData} from "@/services/api"
import {useAppsData} from "@/contexts/app.context"
import {useRouter} from "next/router"
import Image from "next/image"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ import AlertPopup from "@/components/AlertPopup/AlertPopup"
import {useAppTheme} from "../../Layout/ThemeContextProvider"
import {ChatMessage, ChatRole, GenericObject, testset} from "@/lib/Types"
import {removeKeys, renameVariables} from "@/lib/helpers/utils"
import {createNewTestset, loadTestset, updateTestset, useLoadTestsetsList} from "@/lib/services/api"
import {
createNewTestset,
loadTestset,
updateTestset,
useLoadTestsetsList,
} from "@/services/testsets"
import {
Button,
Divider,
Expand Down
4 changes: 2 additions & 2 deletions agenta-web/src/components/Playground/LoadTestsModal.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {loadTestset, useLoadTestsetsList} from "@/lib/services/api"
import {Button, Divider, Dropdown, Modal, Select, Space} from "antd"
import {loadTestset, useLoadTestsetsList} from "@/services/testsets"
import {Button, Divider, Modal, Select} from "antd"
import {useRouter} from "next/router"
import {PropsWithChildren, useState} from "react"
import {createUseStyles} from "react-jss"
Expand Down
3 changes: 2 additions & 1 deletion agenta-web/src/components/Playground/Playground.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import React, {useState, useEffect, useRef} from "react"
import {Button, Tabs, message} from "antd"
import ViewNavigation from "./ViewNavigation"
import NewVariantModal from "./NewVariantModal"
import {fetchEnvironments, fetchVariants, saveNewVariant} from "@/lib/services/api"
import {fetchVariants, saveNewVariant} from "@/services/api"
import {fetchEnvironments} from "@/services/deployment"
import {Variant, PlaygroundTabsItem, Environment} from "@/lib/Types"
import {AppstoreOutlined, SyncOutlined} from "@ant-design/icons"
import {useRouter} from "next/router"
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/components/Playground/ViewNavigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
removeVariant,
restartAppVariantContainer,
waitForAppToStart,
} from "@/lib/services/api"
} from "@/services/api"
import {useAppsData} from "@/contexts/app.context"
import {isDemo} from "@/lib/helpers/utils"
import ResultComponent from "../ResultComponent/ResultComponent"
Expand Down
5 changes: 3 additions & 2 deletions agenta-web/src/components/Playground/Views/ParametersView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,17 @@ import React, {useEffect, useState} from "react"
import {createUseStyles} from "react-jss"
import {ModelParameters, ObjectParameters, StringParameters} from "./ParametersCards"
import PublishVariantModal from "./PublishVariantModal"
import {promptVersioning, removeVariant} from "@/lib/services/api"
import {removeVariant} from "@/services/api"
import {CloudUploadOutlined, DeleteOutlined, HistoryOutlined, SaveOutlined} from "@ant-design/icons"
import {usePostHogAg} from "@/hooks/usePostHogAg"
import {isDemo} from "@/lib/helpers/utils"
import {useQueryParam} from "@/hooks/useQuery"
import {dynamicComponent} from "@/lib/helpers/dynamic"
import {dynamicComponent, dynamicService} from "@/lib/helpers/dynamic"

const PromptVersioningDrawer: any = dynamicComponent(
`PromptVersioningDrawer/PromptVersioningDrawer`,
)
const promptVersioning: any = dynamicService("promptVersioning")

interface Props {
variant: Variant
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {usePostHogAg} from "@/hooks/usePostHogAg"
import {Environment, Variant} from "@/lib/Types"
import {variantNameWithRev} from "@/lib/helpers/variantHelper"
import {fetchEnvironments, publishVariant} from "@/lib/services/api"
import {fetchEnvironments, publishVariant} from "@/services/deployment"
import {Button, Checkbox, Modal, Space, Typography, message} from "antd"
import type {CheckboxChangeEvent} from "antd/es/checkbox"
import {useRouter} from "next/router"
Expand Down
7 changes: 5 additions & 2 deletions agenta-web/src/components/Playground/Views/TestView.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, {useContext, useEffect, useRef, useState} from "react"
import {Button, Input, Card, Row, Col, Space, Form, Modal} from "antd"
import {CaretRightOutlined, CloseCircleOutlined, PlusOutlined} from "@ant-design/icons"
import {callVariant, promptRevision} from "@/lib/services/api"
import {callVariant} from "@/services/api"
import {ChatMessage, ChatRole, GenericObject, Parameter, Variant} from "@/lib/Types"
import {batchExecute, randString, removeKeys} from "@/lib/helpers/utils"
import LoadTestsModal from "../LoadTestsModal"
Expand All @@ -23,6 +23,9 @@ import relativeTime from "dayjs/plugin/relativeTime"
import duration from "dayjs/plugin/duration"
import {useQueryParam} from "@/hooks/useQuery"
import {formatLatency} from "@/lib/helpers/formatters"
import {dynamicService} from "@/lib/helpers/dynamic"

const promptRevision: any = dynamicService("promptVersioning")

dayjs.extend(relativeTime)
dayjs.extend(duration)
Expand Down Expand Up @@ -338,7 +341,7 @@ const App: React.FC<TestViewProps> = ({
usage: {completion_tokens: number; prompt_tokens: number; total_tokens: number} | null
}>
>(testList.map(() => ({cost: null, latency: null, usage: null})))
const [revisionNum, setRevisionNum] = useQueryParam("revision")
const [revisionNum] = useQueryParam("revision")

useEffect(() => {
if (!revisionNum) return
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, {useEffect, useState} from "react"
import {useAppId} from "@/hooks/useAppId"
import {Evaluation, EvaluationScenario} from "@/lib/Types"
import {EvaluationFlow} from "@/lib/enums"
import {createNewTestset} from "@/lib/services/api"
import {createNewTestset} from "@/services/testsets"
import {Form, Input, Modal} from "antd"

type EvaluationRow = EvaluationScenario & {
Expand Down
3 changes: 2 additions & 1 deletion agenta-web/src/components/TestSetTable/TestsetTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import {createUseStyles} from "react-jss"
import {Button, Input, Tooltip, Typography, message} from "antd"
import TestsetMusHaveNameModal from "./InsertTestsetNameModal"
import {DeleteOutlined, EditOutlined, PlusOutlined} from "@ant-design/icons"
import {createNewTestset, fetchVariants, loadTestset, updateTestset} from "@/lib/services/api"
import {fetchVariants} from "@/services/api"
import {createNewTestset, loadTestset, updateTestset} from "@/services/testsets"
import {useRouter} from "next/router"
import {useAppTheme} from "../Layout/ThemeContextProvider"
import useBlockNavigation from "@/hooks/useBlockNavigation"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import {useAppId} from "@/hooks/useAppId"
import {JSSTheme, Variant, LLMRunRateLimit, testset} from "@/lib/Types"
import {evaluatorConfigsAtom, evaluatorsAtom} from "@/lib/atoms/evaluation"
import {apiKeyObject, redirectIfNoLLMKeys} from "@/lib/helpers/utils"
import {fetchTestsets, fetchVariants} from "@/lib/services/api"
import {fetchVariants} from "@/services/api"
import {CreateEvaluationData, createEvalutaiton} from "@/services/evaluations"
import {fetchTestsets} from "@/services/testsets"
import {PlusOutlined, QuestionCircleOutlined} from "@ant-design/icons"
import {
Divider,
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/contexts/app.context.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {ListAppsItem} from "@/lib/Types"
import {getAgentaApiUrl, isDemo} from "@/lib/helpers/utils"
import {axiosFetcher} from "@/lib/services/api"
import {axiosFetcher} from "@/services/api"
import {useRouter} from "next/router"
import {PropsWithChildren, createContext, useContext, useEffect, useMemo, useState} from "react"
import useSWR from "swr"
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/contexts/profile.context.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {usePostHogAg} from "@/hooks/usePostHogAg"
import {useSession} from "@/hooks/useSession"
import useStateCallback from "@/hooks/useStateCallback"
import {isDemo} from "@/lib/helpers/utils"
import {getProfile} from "@/lib/services/api"
import {getProfile} from "@/services/api"
import {User} from "@/lib/Types"
import {PropsWithChildren, createContext, useState, useContext, useEffect, useCallback} from "react"

Expand Down
3 changes: 1 addition & 2 deletions agenta-web/src/lib/helpers/variantHelper.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {Variant, Parameter, InputParameter} from "@/lib/Types"
import {getVariantParametersFromOpenAPI} from "@/lib/services/api"
import {globalErrorHandler} from "./errorHandler"
import {getVariantParametersFromOpenAPI} from "@/services/api"

const inputParamsToParameters = (additionalInputs: InputParameter[]): Parameter[] => {
return additionalInputs.map((value) => ({
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/lib/hooks/useVariant.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {useState, useEffect} from "react"
import {saveNewVariant, updateVariantParams} from "@/lib/services/api"
import {saveNewVariant, updateVariantParams} from "@/services/api"
import {Variant, Parameter} from "@/lib/Types"
import {getAllVariantParameters, updateInputParams} from "@/lib/helpers/variantHelper"
import {PERMISSION_ERR_MSG} from "../helpers/axiosConfig"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import ABTestingEvaluationTable from "@/components/EvaluationTable/ABTestingEvaluationTable"
import {Evaluation} from "@/lib/Types"
import {loadEvaluation, loadEvaluationsScenarios, loadTestset} from "@/lib/services/api"
import {loadEvaluation, loadEvaluationsScenarios} from "@/services/human-evaluations"
import {loadTestset} from "@/services/testsets"
import {useRouter} from "next/router"
import {useEffect, useState} from "react"
import {fetchVariants} from "@/lib/services/api"
import {fetchVariants} from "@/services/api"
import {useAtom} from "jotai"
import {evaluationAtom, evaluationScenariosAtom} from "@/lib/atoms/evaluation"
import {getTestsetChatColumn} from "@/lib/helpers/testset"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import {Evaluation, EvaluationScenario, GenericObject} from "@/lib/Types"
import {loadEvaluation, loadEvaluationsScenarios, loadTestset} from "@/lib/services/api"
import {loadEvaluation, loadEvaluationsScenarios} from "@/services/human-evaluations"
import {loadTestset} from "@/services/testsets"
import {useRouter} from "next/router"
import {useEffect, useState} from "react"
import {fetchVariants} from "@/lib/services/api"
import {fetchVariants} from "@/services/api"
import {getTestsetChatColumn} from "@/lib/helpers/testset"
import SingleModelEvaluationTable from "@/components/EvaluationTable/SingleModelEvaluationTable"

Expand Down
3 changes: 2 additions & 1 deletion agenta-web/src/pages/apps/[app_id]/endpoints/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import {Environment, GenericObject, JSSTheme, Parameter, Variant} from "@/lib/Ty
import {isDemo} from "@/lib/helpers/utils"
import {dynamicComponent} from "@/lib/helpers/dynamic"
import {useVariant} from "@/lib/hooks/useVariant"
import {fetchEnvironments, fetchVariants, getAppContainerURL} from "@/lib/services/api"
import {fetchVariants, getAppContainerURL} from "@/services/api"
import {fetchEnvironments} from "@/services/deployment"
import {ApiOutlined, AppstoreOutlined, HistoryOutlined} from "@ant-design/icons"
import {Alert, Collapse, CollapseProps, Empty, Radio, Tabs, Tooltip, Typography} from "antd"
import {useRouter} from "next/router"
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/pages/apps/[app_id]/testsets/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {ColumnsType} from "antd/es/table"
import {useState} from "react"
import {formatDate} from "@/lib/helpers/dateTimeHelper"
import {DeleteOutlined} from "@ant-design/icons"
import {deleteTestsets, useLoadTestsetsList} from "@/lib/services/api"
import {deleteTestsets, useLoadTestsetsList} from "@/services/testsets"
import {createUseStyles} from "react-jss"
import {testset} from "@/lib/Types"
import {isDemo} from "@/lib/helpers/utils"
Expand Down
Loading
Loading