fix(cosmic-swingset): have make install do what you expect
#4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Nov 19, 2021
michaelfig
added
the
automerge:no-update
michaelfig
force-pushed
the
mfig-fix-make-install-footgun
branch
from
6aefb56 to
08e9d74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes
cd packages/cosmic-swingset && make installan alias formake allto prevent confusion with conventional use ofallandinstallrules.We may someday want to relax
allto just doing compilation and not installation, but our docs currently rely on the existing behaviour.Security Considerations
Documentation Considerations
Testing Considerations