Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agoric-cli): Docker support corrections #4110

Merged
merged 4 commits into from
Nov 23, 2021
Merged

fix(agoric-cli): Docker support corrections #4110

merged 4 commits into from
Nov 23, 2021

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Nov 23, 2021 •
edited
Loading

Changes need to build and use Docker images.

Description

agoric --no-sdk is a way to override an earlier --sdk flag. This is needed to force the use of Docker, for example. Also add default of latest for --docker-tag.

Also, publish nightly images to the latest Docker tag.

Drive-by correction of the Docker build that was broken by #4098.

Security Considerations

Documentation Considerations

Testing Considerations

@michaelfig michaelfig added agoric-cli package: agoric-cli deployment Chain deployment mechanism (e.g. testnet) labels Nov 23, 2021
@michaelfig michaelfig requested a review from dckc November 23, 2021 02:22
@michaelfig michaelfig self-assigned this Nov 23, 2021
dckc
dckc approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit of a stretch to say that I understand the DOCKER_TAG parts of docker.yml well enough to maintain it, but I suppose I could figure it out in a pinch.

@michaelfig michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Nov 23, 2021
@mergify mergify bot merged commit 94e63e3 into master Nov 23, 2021
@mergify mergify bot deleted the mfig-agoric-cli-docker branch November 23, 2021 03:25
This was referenced Feb 11, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

Assignees

@michaelfig michaelfig

Labels
agoric-cli package: agoric-cli automerge:no-update (expert!) Automatically merge without updates deployment Chain deployment mechanism (e.g. testnet)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfig @dckc