-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Track*
/Track *
with Monitor
in CISA-based decision model
#738
Replace Track*
/Track *
with Monitor
in CISA-based decision model
#738
Conversation
In discussions with CISA to update the following locations in their website related to this content. https://www.cisa.gov/profiles/cisad8_gov/modules/custom/ssvc/data/schema_examples/CISA-Coordinator-v2.0.3.json https://www.cisa.gov/profiles/cisad8_gov/modules/custom/ssvc/js/ssvc.js?v=2.x https://www.cisa.gov/sites/default/files/publications/cisa-ssvc-guide%20508c.pdf https://www.cisa.gov/stakeholder-specific-vulnerability-categorization-ssvc |
Track*
or Track *
with Monitor
in CISA-based decision modelTrack*
/Track *
with Monitor
in CISA-based decision model
…ation-of-cisas-tree
This PR modifies the "Track *" value in the CISA OutcomeGroup to be "Monitor". Based on feedback received that having two closely-named values "Track" and "Track *" can be a source of confusion for users of that outcome group.
Two incidental changes are also included:
key
values forAttend
andAct
in the python version of the CISA OutcomeGroup to match the keys found indocs/ssvc-calc/CISA-Coordinator.json
tuple
instead of alist
)CoPilot Summary
This pull request includes several updates to the
docs/ssvc-calc
andsrc/ssvc/outcomes
directories to standardize terminology and improve code structure. The most important changes include renaming "Track*" to "Monitor" in JSON and HTML files, updating theOutcomeGroup
class to use tuples instead of lists, and restructuring outcome groups in the codebase.Terminology Standardization:
docs/ssvc-calc/CISA-Coordinator.json
: Renamed "Track*" to "Monitor" in multiple entries to standardize terminology. [1] [2] [3] [4] [5]docs/ssvc-ccalc/findex.html
anddocs/ssvc-calc/old_index.html
: Updated "Track*" to "Monitor" in the vulnerability scoring decisions section. [1] [2]Code Structure Improvements:
src/ssvc/outcomes/base.py
: Changed theoutcomes
attribute in theOutcomeGroup
class from a list to a tuple for better immutability and performance.src/ssvc/outcomes/groups.py
: Updated theOutcomeGroup
instances to use the new "Monitor" terminology and restructured the CISA outcome group. Additionally, added new descriptions and keys for the "Act" outcome. [1] [2] [3] [4] [5] [6]