Replace Track*
/Track *
with Monitor
in CISA-based decision model (2nd try)
#742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #738, which we merged too soon and reverted in #741
This PR modifies the "Track *" value in the CISA OutcomeGroup to be "Monitor". Based on feedback received that having two closely-named values "Track" and "Track *" can be a source of confusion for users of that outcome group.
Two incidental changes are also included:
key
values forAttend
andAct
in the python version of the CISA OutcomeGroup to match the keys found indocs/ssvc-calc/CISA-Coordinator.json
tuple
instead of alist
)CoPilot Summary
This pull request includes several updates to the
docs/ssvc-calc
andsrc/ssvc/outcomes
directories to standardize terminology and improve code structure. The most important changes include renaming "Track*" to "Monitor" in JSON and HTML files, updating theOutcomeGroup
class to use tuples instead of lists, and restructuring outcome groups in the codebase.Terminology Standardization:
docs/ssvc-calc/CISA-Coordinator.json
: Renamed "Track*" to "Monitor" in multiple entries to standardize terminology. [1] [2] [3] [4] [5]docs/ssvc-ccalc/findex.html
anddocs/ssvc-calc/old_index.html
: Updated "Track*" to "Monitor" in the vulnerability scoring decisions section. [1] [2]Code Structure Improvements:
src/ssvc/outcomes/base.py
: Changed theoutcomes
attribute in theOutcomeGroup
class from a list to a tuple for better immutability and performance.src/ssvc/outcomes/groups.py
: Updated theOutcomeGroup
instances to use the new "Monitor" terminology and restructured the CISA outcome group. Additionally, added new descriptions and keys for the "Act" outcome. [1] [2] [3] [4] [5] [6]