Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add soft-filter-normal argument to paired tga analyses #4157

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

mathiasbio
Copy link
Contributor

@mathiasbio mathiasbio commented Jan 27, 2025

Description

DO NOT MERGE UNTIL BALSAMIC RELEASE 17.0.0 HAS BEEN VALIDATED AND DEPLOYED

Update required to enable this new feature in balsamic (planned for balsamic release 17.0.0): Clinical-Genomics/BALSAMIC#1509

Added

  • default option to disable normal filtration for tumor normal matched TGA analyses in balsamic

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • soft-filter-normal is applied for TN case

image

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@mathiasbio mathiasbio marked this pull request as ready for review March 4, 2025 13:37
@mathiasbio mathiasbio requested a review from a team as a code owner March 4, 2025 13:37
Copy link

sonarqubecloud bot commented Mar 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant