-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(keycloak authentication) #4162
base: master
Are you sure you want to change the base?
Conversation
… into feat-keycloak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These endpoints will handle the talk with keycloak
|
def __init__(self, config: dict): | ||
self.service_account = config["trailblazer"]["service_account"] | ||
self.service_account_auth_file = config["trailblazer"]["service_account_auth_file"] | ||
def __init__(self, config: dict, keycloak_client: KeycloakClient): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part needs to be tested on hasta-stage with the cli commands.
Description
Implements keycloak as authirsation and verification provider for CG
Added
AuthenticationService
Handles logic pertaining to authentication and token verification of users
UserService
handles fetching of users from the database - introduced to reduce coupling of database to endpoints
New endpoints:
auth/login
auth/callback
auth/logout
New config settings in the Flask AppConfig to initiate the authentication service
Changed
Moved app.route("/") to its own blueprint to cleanup the _register_blueprint() function. Increased code clarity
Removed google oauth flow from front end
Fixed
closes: #4159
How to prepare for test
us
paxa
How to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan