Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV - Start pipelines #4227

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

DEV - Start pipelines #4227

wants to merge 20 commits into from

Conversation

diitaz93
Copy link
Contributor

@diitaz93 diitaz93 commented Feb 19, 2025

Description

Development branch that closes #4031

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

diitaz93 and others added 13 commits February 19, 2025 12:54
add first structure in services
…#4231) (patch)

### Added

- Seqera platform submitter
- Seqera platform client
### Added

- SeqeraPlatformConfig
- Method bodies in the SeqeraPlatformClient
## Description

### Added

- Abstract Configurator class with abstract method create_config
- Base CaseConfig model with attributes `workflow` and `case_id`
- RarediseaseConfigurator that creates valid CaseConfig
- RarediseaseCaseConfig with attributes `case_priority`, `netxflow_config_file`, `params_file`, and `work_dir`
- Fixtures for
  -  RarediseaseCaseConfig
  - RarediseaseConfigurator
  - dummy directories
- Unit test for Raredisease create_config 

### Changed

- Separated abstract module into model and service
### Added

- DTOs for the Seqera platform endpoints
- Tests for the SeqeraPlatformClient
## Description
Une one CaseConfig for all nextflow pipelines

### Added

- Method `_get_case_workflow` to get the workflow inside the NetflowConfigurator

### Changed

- Renamed `RarediseaseCaseConfig` to `NextflowCaseConfig`
- Names of fixtures

### Fixed

- Removed currently unused elements from config in Configurator
## Description
Add infrastructure to build nextflow config files in the RareDisease configurator

### Added

- necessary config attributes to build nextflow config to the init of the `RarediseaseConfigurator`
- Implemented necessary methods in `RarediseaseConfigurator`
- utils module
- fixtures
- test `for_get_nextflow_config_content`

### Fixed

- Removed `__init__` method in abstract class configurator.
diitaz93 and others added 7 commits March 3, 2025 10:45
## Description

### Fixed

- Updates the way of getting the QOS (Slurm priority) whichcasued tests to fail
…(patch)

* add code for the params file

* add creation of file in create_cpnfig

* fix 2 out of 3 failing tests

* add also sample sheet code to configurator

* fix fixture

* add skeleton of new classes

* resolve conflicts

* stash commit

* enhance sample sheet and config

* unify classes

* stash commit

* remove out of scope change

* created a nextflow level of inheritance in configurator

* add constants for gene files

* removed duplicated utils method

* renamed write function

* rolled back small fix for scope reasons

* inject content creators

* add gene panel creator

* some renaming

* add sample sheet creator fixture

* add params file creator fixture

* add other file creator fixtures

* add fixtures in plugins to conftest

* fix constructors and fixtures

* Add managed_variants support (#4265) (patch)

### Added

- ManagedVariantsFileContentCreator

* add first tests for content creation

* Rework raredisease extension (#4266)

* Add managed_variants support

* Inject creators

* Inject creators

* Inject creators

* Refactor Raredisease configurator into extension

* Fix type hint

* Fix fixtures

* Fix test

* remove inheritance of nextflow configurator (#4267)

* remove inheritance of nextflow configurator

* add sample sheet path as parameter to params

* fix sample sheet path in configurator

* address comments

* fi sample sheet fixture (#4270)

* add todo

* fix samplesheet path fixture

* Implement Raredisease Extension (#4271)

* move raredisease models to the analysis starter directory

* rename content creator files

* add tests for managed variants

* add tests for gene panel

* fix sample sheet creator

* fix creator

* fix sample sheet test

* Address comments

* Remove TODO

* Fix typo

* Make interface

* Revert interface

---------

Co-authored-by: Isak Ohlsson Ångnell <[email protected]>
Co-authored-by: islean <[email protected]>
* Initial commit

* Change name

* Make private

* Mark as abstract method

* Inject spring archive API

* Remove dry run

* Remove dry run

* (Pipeline Integration) Merge PrepareFastqAPI into the FastqFetcher (#4277) (patch)

* Merge PrepareFastqAPI into the FastqFetcher

* Add docstrings

* Fix sample check

* Move to CompressAPI

* Return to continue

* Address comments

* Address comments
### Fixed

- Raredisease extension is properly tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pipeline integration] Starting pipelines
2 participants