Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Pipeline implementation) Implement seqera submitter #4243

Open
wants to merge 34 commits into
base: dev-start-pipelines
Choose a base branch
from

Conversation

islean
Copy link
Contributor

@islean islean commented Feb 24, 2025

Description

Added

  • Method body for _create_launch_request

Changed

Fixed

  • Added a test for the submitter

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean changed the base branch from master to dev-start-pipelines February 24, 2025 13:14
Comment on lines 33 to 38
parameters: dict = ReadFile.get_content_from_file(
file_format=FileFormat.YAML, file_path=case_config.params_file
)
parameters_as_string = WriteStream.write_stream_from_content(
content=parameters, file_format=FileFormat.YAML
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit ugly - happy to take suggestions if there are easier ways to read the file contents into a yaml formatted string

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could create a function in the ReadFile module get_stream_from_file that does this

@islean islean marked this pull request as ready for review February 25, 2025 10:24
@islean islean requested a review from a team as a code owner February 25, 2025 10:24
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good 💪 I left some comments regarding your doubts

…ubmitter

# Conflicts:
#	cg/services/analysis_starter/configurator/implementations/raredisease.py
Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

islean added 9 commits March 11, 2025 13:06
…ubmitter

# Conflicts:
#	cg/services/analysis_starter/configurator/implementations/raredisease.py
#	cg/services/analysis_starter/configurator/models/nextflow.py
#	tests/conftest.py
#	tests/fixture_plugins/analysis_starter/case_config_fixtures.py
#	tests/fixture_plugins/analysis_starter/path_fixtures.py
Comment on lines 11 to 22
def raredisease_repository() -> str:
return "http://some_url"


@pytest.fixture
def raredisease_revision() -> str:
return "2.2.0"


@pytest.fixture
def raredisease_config_profiles() -> list[str]:
return ["myprofile"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have to match the parameters in the context_config fixture. Would it use these there instead? Or should these fixtures take the context_config as input?

params_file=raredisease_params_file_path.as_posix(),
pipeline_repository=raredisease_repository,
pre_run_script="",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, no data here. Maybe we should populate it but seems a bit early to go into such detail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants