Finish maplibre upgrade

[nabramow]

Closes #5106

Upgrading maplibre to the most recent stable version 4.7.1.

v3 had no breaking changes for us.

v4 had these breaking changes that were addressed:
Guide: https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#400

• ⚠️ Removed callback usage from map.loadImage in continue to below change (Remove callback from loadImage maplibre/maplibre-gl-js#3422)
• ⚠️ Changed the GeoJSONSource's getClusterExpansionZoom, getClusterChildren, getClusterLeaves methods to return a Promise instead of a callback usage (Change geojson source API to use promises maplibre/maplibre-gl-js#3421)
• ⚠️ Changed the map.loadImage method to return a Promise instead of a callback usage (Async Actor maplibre/maplibre-gl-js#3233)

Besides that, I:

• Changed MapMouseEvent & { features: etc } to MapLayerMouseEvent as it's the same thing and shorter
• Removed MaplibreEvent as it no longer exists in the package and I removed it from related types. It didn't seem to have any effect so assuming this got deprecated and they forgot to document it.

Web frontend checklist

• [ x ] Formatted my code with yarn format
• [ x ] There are no warnings from yarn lint --fix
• [ x ] There are no console warnings when running the app
• [ x ] All tests pass
• [ x ] Clicked around my changes running locally and it works
• [ x ] Checked Desktop, Mobile and Tablet screen sizes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
couchers	✅ Ready (Inspect)	Visit Preview	Nov 7, 2024 5:57am

[nabramow]

See MapLayerMouseEvent is the same type here: https://github.com/maplibre/maplibre-gl-js/blob/91e49458f9c06726550510e94ee549c380c81f38/src/ui/events.ts#L17

[aapeliv]

LGTM!

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ TypeError: undefined is not an object (evaluating 'this.style.getImage') call(features/search/users) View Issue

_{Did you find this useful? React with a 👍 or 👎}

[bakeiro]

@nabramow error here after this PR
also, seems that doesn't move after search a location?

if (map.hasImage("user-pin")) return;

[nabramow]

@nabramow error here after this PR also, seems that doesn't move after search a location?

if (map.hasImage("user-pin")) return;

Made a ticket to deal with it here #5152