Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Fix bbox value #5143

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Bug - Fix bbox value #5143

merged 4 commits into from
Nov 10, 2024

Conversation

nabramow
Copy link
Member

I was working on another branch, clicking around to make sure I didn't break anything. I noticed when I searched a location on the map, it jumped to a random unrelated place.

I replicated this on prod, so seems it's a bug. Since I recently upgraded maplibre in #5119 , I thought maybe I broke something.

But in the end seems like we were putting the bbox values in the wrong order on search?! So either this has been a longstanding issue we didn't notice or ???.

I guess the NominatumPlace could have also changed via that api call, but that also does not make sense tbh.

But hey...it works?!

Definitely test this one though in case I'm going crazy!. I tested a lot myself but I still don't understand why we had this bug to begin with.

Web frontend checklist

  • [ x ] Formatted my code with yarn format
  • [ x ] There are no warnings from yarn lint --fix
  • [ x ] There are no console warnings when running the app
  • [ x ] All tests pass
  • [ x ] Clicked around my changes running locally and it works
  • [ x ] Checked Desktop, Mobile and Tablet screen sizes

Copy link

vercel bot commented Nov 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
couchers ✅ Ready (Inspect) Visit Preview Nov 10, 2024 4:53pm

@bakeiro
Copy link
Contributor

bakeiro commented Nov 10, 2024

I think this is new 🙃 I tested with locations that were working nicely before and now seems they don't... I gonna check this as well!

@bakeiro
Copy link
Contributor

bakeiro commented Nov 10, 2024

I pushed a small commit, the dashboard needed a small fix as well

bakeiro
bakeiro previously approved these changes Nov 10, 2024
@bakeiro bakeiro merged commit af9ddeb into develop Nov 10, 2024
3 checks passed
@bakeiro bakeiro deleted the web/fix/map-fitBounds branch November 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants