Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply view tag to reduce sync time #50

Merged
merged 5 commits into from
Dec 6, 2022

Conversation

thanhdanh
Copy link

@thanhdanh thanhdanh commented Nov 13, 2022

Summary

One of the most common complaints around using Monero day-to-day is the time that it can take to sync up a wallet before being able to send Monero. As a solution to help reduce the synchronization time for Monero wallets, a researcher named UkoeHB came up with a novel approach – add a 1-byte “tag” to each transaction using a shared secret known only to the sender and receiver of that transaction.

Article: link

To apply view_tag:

  • Download each block to get a list of transactions (
  • Go through each transaction and get its view_tag if have (for all blocks that exist before the HF 16, no have view_tag filed in the transaction)
  • Derive the view tag from the wallet account and then check with the tx's view_tag
  • If the output's view tag does not match the derived view tag, the output should not belong to the account.

Depending on:

@thanhdanh thanhdanh self-assigned this Nov 13, 2022
@thanhdanh thanhdanh requested a review from feri42 November 13, 2022 17:54
@thanhdanh thanhdanh added the enhancement New feature or request label Nov 13, 2022
Copy link

@feri42 feri42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@thanhdanh thanhdanh merged commit c2f0784 into master Dec 6, 2022
@thanhdanh thanhdanh deleted the andyvo/apply-view-tag-to-reduce-sync-time branch December 7, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants