Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply view tag to reduce sync time #62

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

thanhdanh
Copy link

Summary

Apply view-tag to reduce the sync time on mobile.

Mirror of PR#50

@thanhdanh thanhdanh added the enhancement New feature or request label Dec 7, 2022
@thanhdanh thanhdanh requested review from feri42 and RyanZim December 7, 2022 17:23
@thanhdanh thanhdanh self-assigned this Dec 7, 2022
@RyanZim RyanZim removed their request for review December 7, 2022 21:38
@feri42 feri42 requested a review from andrejborstnik December 8, 2022 09:08
Copy link

@andrejborstnik andrejborstnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@@ -75,8 +75,8 @@ set(
${MONERO_SRC}/cryptonote_core/cryptonote_tx_utils.cpp
${MONERO_SRC}/common/base58.cpp
${MONERO_SRC}/common/aligned.c
# ${MONERO_SRC}/common/threadpool.cpp
# ${MONERO_SRC}/common/util.cpp
${MONERO_SRC}/common/threadpool.cpp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we running multiple threads now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrejborstnik , the max concurrency thread is 1, so it seems not running as a multi-thread.

@thanhdanh thanhdanh merged commit c669c59 into master Dec 20, 2022
@thanhdanh thanhdanh deleted the andyvo/apply-view-tag branch December 20, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants