[HOLD for payment 2023-09-27] [$500] webpack-dev-server warnings show in JS console

[marcaaron]

cc @cead22

Let's fix these.

index.js:556 [webpack-dev-server] Warnings while compiling.
logger @ index.js:556
eval @ index.js:730
warn @ index.js:189
warnings @ index.js:234
eval @ socket.js:60
client.onmessage @ WebSocketClient.js:50
index.js:556 [webpack-dev-server] WARNING in ./node_modules/react-native-performance/lib/module/NativeRNPerformanceManager.js 2:15-38
export 'TurboModuleRegistry' (imported as 'TurboModuleRegistry') was not found in 'react-native' (possible exports: AccessibilityInfo, ActivityIndicator, Alert, Animated, AppRegistry, AppState, Appearance, BackHandler, Button, CheckBox, Clipboard, DeviceEventEmitter, DeviceInfo, Dimensions, DrawerLayoutAndroid, Easing, FlatList, I18nManager, Image, ImageBackground, InputAccessoryView, InteractionManager, Keyboard, KeyboardAvoidingView, LayoutAnimation, Linking, LogBox, Modal, NativeEventEmitter, NativeModules, PanResponder, PermissionsAndroid, Picker, PixelRatio, Platform, Pressable, ProgressBar, RefreshControl, SafeAreaView, ScrollView, SectionList, Settings, Share, StatusBar, StyleSheet, Switch, Systrace, TVEventHandler, Text, TextInput, ToastAndroid, Touchable, TouchableHighlight, TouchableNativeFeedback, TouchableOpacity, TouchableWithoutFeedback, UIManager, Vibration, View, VirtualizedList, YellowBox, findNodeHandle, processColor, render, unmountComponentAtNode, unstable_createElement, useColorScheme, useLocaleContext, useWindowDimensions)
logger @ index.js:556
eval @ index.js:730
warn @ index.js:189
warnings @ index.js:247
eval @ socket.js:60
client.onmessage @ WebSocketClient.js:50
index.js:556 [webpack-dev-server] WARNING in ./node_modules/react-native-svg/lib/module/ReactNativeSVG.web.js 8:22-24
export 'createElement' (imported as 'cE') was not found in 'react-native' (possible exports: AccessibilityInfo, ActivityIndicator, Alert, Animated, AppRegistry, AppState, Appearance, BackHandler, Button, CheckBox, Clipboard, DeviceEventEmitter, DeviceInfo, Dimensions, DrawerLayoutAndroid, Easing, FlatList, I18nManager, Image, ImageBackground, InputAccessoryView, InteractionManager, Keyboard, KeyboardAvoidingView, LayoutAnimation, Linking, LogBox, Modal, NativeEventEmitter, NativeModules, PanResponder, PermissionsAndroid, Picker, PixelRatio, Platform, Pressable, ProgressBar, RefreshControl, SafeAreaView, ScrollView, SectionList, Settings, Share, StatusBar, StyleSheet, Switch, Systrace, TVEventHandler, Text, TextInput, ToastAndroid, Touchable, TouchableHighlight, TouchableNativeFeedback, TouchableOpacity, TouchableWithoutFeedback, UIManager, Vibration, View, VirtualizedList, YellowBox, findNodeHandle, processColor, render, unmountComponentAtNode, unstable_createElement, useColorScheme, useLocaleContext, useWindowDimensions)
logger @ index.js:556
eval @ index.js:730
warn @ index.js:189
warnings @ index.js:247
eval @ socket.js:60
client.onmessage @ WebSocketClient.js:50
index.js:556 [webpack-dev-server] WARNING in ./src/libs/actions/Device/getDeviceInfo/getBaseInfo.js 4:17-24
Should not import the named export 'version' (imported as 'version') from default-exporting module (only default export is available soon)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0188c71c3d9384236e
• Upwork Job ID: 1700244683779788800
• Last Price Increase: 2023-09-08

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[lschurr]

Need anything from BZ on this @marcaaron? Should this be assigned to an Engineer?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0188c71c3d9384236e

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[marcaaron]

yep I think we are just treating it as a "bug".

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

webpack-dev-server warnings show up in console.

What is the root cause of that problem?

1. We're not using the latest version of react-native-svg package (The version we are using uses a deprecated import which got fixed here).
2. We're importing version from package.json as a named import.
3. We're using an outdated version of react-native-performance. The current version supports the new RN architecture till react-native version 0.71. Our version currently is 0.72. (Update configuration for the new architecture oblador/react-native-performance#94)

What changes do you think we should make in order to solve the problem?

1. Update react-native-svg to 13.13.0 (https://github.com/software-mansion/react-native-svg/releases/tag/v13.10.0) (fix: remove deprecated import from react-native-web software-mansion/react-native-svg#2027).
2. Replace the import statement here with import packageConfig from '../../../../../package.json' and use packageConfig.version instead.
3. Update react-native-performance package to 5.1.0.

What alternative solutions did you explore? (Optional)

None

[parasharrajat]

We're not using the latest version of react-native-svg package.
We're importing version from package.json as a named import.
We're using an outdated version of react-native-performance.

This can't be stated as root cause.

@allroundexperts Did you test these upgrades? Also, if we are upgrading, what other changes are required for migration?

[allroundexperts]

@parasharrajat Yes. I tested these and they seem to work fine.

I've also updated the RCA with the exact fix PRs.

I don't think there is anything needed for migration because:

1. For react-native-svg we're just updating the minor version (no breaking changes).
2. For react-native-performance, we're introducing a breaking change, but that needs to be done in order to support the latest RN version that we're using.

[allroundexperts]

Demo

Screen.Recording.2023-09-09.at.2.13.57.AM.mov

[parasharrajat]

Ok. Thanks. I don't expect anyone to lay down all the required changes. Testing is sufficient which signifies that you made sure that the app is working after these changes. If something unexpected is found on PR, then it will have to be handled as part of this issue.

On this note, I am fine with @allroundexperts's proposal.

There is a Performance.js lib which will also need to be migrated and tested against the new version.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[lschurr]

Bump @marcochavezf :)

[marcochavezf]

Assigning @allroundexperts here 🚀

[melvin-bot]

📣 @parasharrajat Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Contributor role ($500)

[allroundexperts]

PR created!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: update some package versions to avoid console warnings #27289

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat / @allroundexperts] Determine if we should create a regression test for this bug.
• [@parasharrajat / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@parasharrajat] Determine if we should create a regression test for this bug. N/A
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[lschurr]

Payment summary for 2023-09-27:

• Bug reporter: N/A
• Contributor: @allroundexperts $500
• Contributor+: @parasharrajat $500

[lschurr]

@parasharrajat and @allroundexperts - go ahead and request payment in NewDot for these. Going to close this one out.

[parasharrajat]

Payment requested as per #26987 (comment)

[JmillsExpensify]

$500 payment approved for @allroundexperts based on BZ summary.

[JmillsExpensify]

$500 payment approved for @parasharrajat based on BZ summary.