Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration for the new architecture #94

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

j-piasecki
Copy link
Contributor

This PR:

This PR makes the library no longer support RN below 0.71 on the new architecture.

Copy link

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@oblador
Copy link
Owner

oblador commented Jul 10, 2023

Thanks for your PR! I take it this is a breaking change? Any way to keep backwards compatibility?

@oblador
Copy link
Owner

oblador commented Jul 10, 2023

Btw, looking into why tests are failing. It seems some flipper dependency got deleted from the registry: samdenty/console-feed#124

@j-piasecki
Copy link
Contributor Author

Yes, it's breaking but only for the new architecture.
As for keeping backward compatibility:

  • for the podspec change, it's not necessary, and dependencies can be listed manually, however if something is added/removed in future it could cause problems
  • conditional react-native implementation in build.gradle can be kept but requires some gradle tricks to figure out what version of RN is used in the app, but there are some edge-cases with monorepos
  • removal of react block from build.gradle should be non-breaking
  • schema used currently for codegenConfig is still supported, although I don't know whether it's going to be removed

@WoLewicki
Copy link

Since on new arch we drop the support for the older versions in the rest of the libraries, I think it is safe to do it here also.

@oblador
Copy link
Owner

oblador commented Jul 10, 2023

Yeah, if it's only new arch I'm fine with it 👍

@oblador
Copy link
Owner

oblador commented Jul 10, 2023

Was a lot of work, but finally resolved the dependency and updated to RN 0.72. Would you mind rebasing and also enabling new arch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants