-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuration for the new architecture #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Thanks for your PR! I take it this is a breaking change? Any way to keep backwards compatibility? |
Btw, looking into why tests are failing. It seems some flipper dependency got deleted from the registry: samdenty/console-feed#124 |
Yes, it's breaking but only for the new architecture.
|
Since on new arch we drop the support for the older versions in the rest of the libraries, I think it is safe to do it here also. |
Yeah, if it's only new arch I'm fine with it 👍 |
Was a lot of work, but finally resolved the dependency and updated to RN 0.72. Would you mind rebasing and also enabling new arch? |
This PR:
build.gradle
:react
block, since RNGP resolves the paths by default (see https://github.com/facebook/react-native/blob/main/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactExtension.kt) and other fields are provided inpackage.json
codegenConfig
inpackage.json
to match the new config schema (see https://reactnative.dev/docs/new-architecture-library-intro#configure-codegen`This PR makes the library no longer support RN below 0.71 on the new architecture.