Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration for the new architecture #94

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Update configuration for the new architecture #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
134fd80
Update `build.gradle`
j-piasecki Jul 10, 2023
904a751
Update podspec
j-piasecki Jul 10, 2023
02d280b
Update `codegenConfig`
j-piasecki Jul 10, 2023
8f3cf9e
Enable new arch on android
j-piasecki Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/vanilla/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
# your application. You should enable this flag either if you want
# to write custom TurboModules/Fabric components OR use libraries that
# are providing them.
newArchEnabled=false
newArchEnabled=true

# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
Expand Down
16 changes: 1 addition & 15 deletions packages/react-native-performance/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,19 +100,5 @@ repositories {
}

dependencies {
if (isNewArchitectureEnabled()) {
implementation project(":ReactAndroid")
} else {
implementation 'com.facebook.react:react-native:+'
}
}

if (isNewArchitectureEnabled()) {
react {
libraryName = "rnperformance"
codegenJavaPackageName = "com.oblador.performance"
reactNativeDir = rootProject.file("${nodeModules}/react-native")
jsRootDir = file("../src/")
codegenDir = rootProject.file("${nodeModules}/react-native-codegen")
}
implementation 'com.facebook.react:react-native:+'
}
13 changes: 6 additions & 7 deletions packages/react-native-performance/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,12 @@
"typescript": "^4.8.3"
},
"codegenConfig": {
"libraries": [
{
"name": "RNPerformanceSpec",
"type": "modules",
"jsSrcsDir": "src"
}
]
"name": "RNPerformanceSpec",
"type": "modules",
"jsSrcsDir": "./src",
"android": {
"javaPackageName": "com.oblador.performance"
}
},
"react-native-builder-bob": {
"source": "src",
Expand Down
6 changes: 1 addition & 5 deletions packages/react-native-performance/react-native-performance.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ Pod::Spec.new do |s|
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
}

s.dependency "React-Codegen"
s.dependency "RCT-Folly"
s.dependency "RCTRequired"
s.dependency "RCTTypeSafety"
s.dependency "ReactCommon/turbomodule/core"
install_modules_dependencies(s)
end
end