reorganise transport_paths lemmas and add tests #2253
+305
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Comment on lines
+241
to
+242
| | [ |- transport (fun x => ?y = ?h (?gg (?f x))) ?p ?q = ?r ] | ||
| => lhs exact (transport_paths_FFFr (f:=f) (g:=gg) (h:=h) p q) |
There was a problem hiding this comment.
Why gg instead of g?
jdchristensen
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we reorganise our
transport_pathslemmas, grouping them by number of functions and putting them in order of left to right. We also test the associated tactics expected usage making sure things are working as expected. We also add some missing lemmas and fix some mistakes observed during testing.There is a unification problem in one of the tactics that I wasn't able to understand, so I will mark this as draft for now.