Stack overflow error

[sidnair]

brew at head doesn't work for me. I'm on a brand new OS X 10.7.3.

I installed successfully with the install_homebrew.rb script, but running any brew command fails.

Here's the trace:
$ brew
/usr/local/Library/Homebrew/utils.rb:385:in 'xctools_fucked?': stack level too deep (SystemStackError)
from /usr/local/Library/Homebrew/utils.rb:302:in 'locate'
from /usr/local/Library/Homebrew/utils.rb:339:in 'dev_tools_path'
from /usr/local/Library/Homebrew/utils.rb:313:in 'locate'
from /usr/local/Library/Homebrew/utils.rb:339:in 'dev_tools_path'
from /usr/local/Library/Homebrew/utils.rb:313:in 'locate'
from /usr/local/Library/Homebrew/utils.rb:339:in 'dev_tools_path'
from /usr/local/Library/Homebrew/utils.rb:313:in 'locate'
from /usr/local/Library/Homebrew/utils.rb:339:in 'dev_tools_path'
... 661 levels...
from /usr/local/Library/Homebrew/utils.rb:339:in 'dev_tools_path'
from /usr/local/Library/Homebrew/global.rb:96
from /usr/local/bin/brew:10:in 'require'
from /usr/local/bin/brew:10

It looks like this is caused by commit 3c52a30. locate and dev_tools_path call each other on the lines in the stack trace. I checked out brew at the commit before that and extracted it to /usr/local, and it worked.

[MikeMcQuaid]

Paging @samueljohn.

[Sharpie]

Just for reference, which version of OS X and Ruby are you using? This works fine for me on 10.7.3 and ruby 1.8.7 so there may be another factor influencing this error.

[sidnair]

That's weird...I'm on OS X 10.7.3 and ruby 1.8.7 as well.

ruby --v: ruby 1.8.7 (2010-01-10 patchlevel 249) [universal-darwin11.0]

[jacknagel]

I think that this code path is only hit if the CLT is not installed? Regardless, clearly these methods should not call each other.

[wronco]

I experienced this same problem - after installing Xcode and letting it run its setup tasks, I no longer get the error. I agree with jacknagel above, though, it would probably be great if the methods did not call each other.

[jbajor]

Have you installed Command Line Tools? 'XCode' -> 'Preferences' -> 'Downloads'.

[sidnair]

I had installed XCode, but hadn't touched it at all. So, command line tools weren't installed and the xcode-select path was /Development, which didn't exist, instead of /Applications/Xcode.app/Contents/Developer.

[samueljohn]

O.o oh what have I done?
Will have a look tomorrow. Never have seen this in my tests.

[MikeMcQuaid]

Very quick and dirty fix attempt but can someone who can still reproduce this try 0b2665a (updated) from #13021. Thanks!

[MikeMcQuaid]

And if that sucks can you suggest a better solution? Otherwise we need to revert.

[jbajor]

I have had the same error. Installing "Command Line Tools" for XCode solved the problem (as I suggested an hour ago). You obviously cannot run tools like 'strip' or 'gcc' if they are not installed. Believe me, brew is working fine on 10.7.3/4.

[mistydemeo]

Hotfix pushed in 78b9e85.

Can someone with only Xcode and no Command Line Tools please test? This should fix the recursion and also make builds work.

[stevewanless]

I just installed Homebrew a little while ago. Got the documented error;
/usr/local/Library/Homebrew/utils.rb:385:in `xctools_fucked?': stack level too deep (SystemStackError)

Made the change from mistydemeo and it's now working

[mistydemeo]

Thank you, @stevewanless. Can you try installing some software, and tell me if that works?

[MikeMcQuaid]

All hail @mistydemeo!

[samueljohn]

At first sorry all, that was my fault and I couldn't respond yesterday timely.

I analyzed the issue. The good news: None of the existing homebrew users are affected so there need to revert.

On systems with only Xcode (that was not supported at all up to now) which have xcode-select set to a wrong path (like /Developer which does not exist on a fresh Lion) the method MacOS.locate(tool) resorts to the find the tool in MacOS.dev_tools_path. And my assumption that unless xctools_fucked?, I can use /usr/bin/xcrun does not hold, obviously.

Thanks @mistydemeo for your patch. We could also make xctools_fucked? always check if the directory does exist. That would also have solved the recursion thingy.

[samueljohn]

I think I have a proper fix (#13037) for this issue by assuring that it's safe to call locate from dev_tools_path by checking

elsif not xctools_fucked? and system "/usr/bin/xcrun -find make 1>/dev/null 2>&1".

Now, it's safe to call locate, because we know that xcrun can find "make".

I have tested this with different settings of xcode-select (hint: sudo vim /usr/share/xcode-select/xcode_dir_path) for Xcode-only and CLT-only on Lion.

[samueljohn]

Oh forgot to say, that I was able to reproduce on my Xcode-only setup when xcode-select points to nonexistant /Developer.

[spark85]

Hi, I'm still having this problem. How do I fix it? How do I install or use this fix?

[samueljohn]

Exactly this problem? I doubt it. Unless you haven't updated since then. Please brew update and if your issue still remains please open a new issue @spark85.

[spark85]

I ran brew update and everything was already up to date. When I try and run 'gem install pg' it does not install, because it does not find the PostgreSQL libraries.

Let me give you more background on the problems I'm experiencing.
I am trying install Ruby on Rails on Heroku. When I try and build a project with the 'pg' database, I get an error that the database can't be found.

The command bundle install leads to this errror:

Gem::Installer::ExtensionBuildError: ERROR: Failed to build gem native extension.

    /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby extconf.rb 

checking for pg_config... yes
Using config values from /usr/bin/pg_config
checking for libpq-fe.h... yes
checking for libpq/libpq-fs.h... yes
checking for pg_config_manual.h... yes
checking for PQconnectdb() in -lpq... no
checking for PQconnectdb() in -llibpq... no
checking for PQconnectdb() in -lms/libpq... no
Can't find the PostgreSQL client library (libpq)
*** extconf.rb failed ***
.
.
.
.An error occurred while installing pg (0.14.1), and Bundler cannot continue.
Make sure that gem install pg -v '0.14.1' succeeds before bundling.

So I've run 'gem install pg -v 0.14.1' which does not return any error message, but it also doesn't fix the problem.
I found the Gem on my filesystem, and checked the log file gem_make.out file, and I find the samy error message from before.

Online I was advised to re install PostgreSQL first, either with their installer script or using brew. Other people suggested adding the pg_config file to the path variable. That seemed to solve the problem for many people, but not for me.

On another note, in the process of installing the EnterpriseDB script, the wizard wanted me to connect to a database on port 5342, which it didn't seem to create.

I believe the libraries are installed correctly, but the Heroku installer is looking for some file in the wrong place, or with a different name, or some other conflict.

Thank you,

[jacknagel]

...none of that has anything to do with this issue.

I can install the pg gem against Homebrew's postgresql without issue. Try asking on stackoverflow or something.

[spark85]

Hi...I need to add arguements to the bundle install. Sorry for complaining.