This repository was archived by the owner on Jan 16, 2025. It is now read-only.
Stop recursion madness. #13021
Closed
Stop recursion madness. #13021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Introduces a new bug ;) That makes |
Should fix #13012 due from issue introduced in 3c52a3.
|
Try 0b2665a. |
|
And if that sucks can you suggest a better solution? Otherwise we need to revert. |
|
Pushed an alternate solution, tested with a user on IRC. This should also make Xcode-only builds work, since there were a couple of related bugs. |
|
(My push is somewhat of a sledgehammer solution, but calling Commit in 78b9e85 |
|
Great, thanks @mistydemeo! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #13012 due from issue introduced in 3c52a3.