-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Conversation
I am not a valgrind expert, I have to admit, but I can successfully build valgrind now. |
What is the source of the patch? Has it been reported upstream? The patch will need some documentation. |
@adamv I reported this in February to the valgrind tracker. No response so far. I even attached the git diff. The core devs don't seem to have access to Macs. The patch is done by me. It's really simple in the sense that I have looked at their Makefiles and fixed the hard coded pathes. The patch is only applied on xcode-only systems. Given that the valgrind devs have not responded yet, I thought we might want to patch this for homebrew until they care about. |
These: ENV.remove_from_cflags '-mmacosx-version-min=10.7'
ENV.remove 'CXXFLAGS', '-mmacosx-version-min=10.7' Should probably by ENV.remove 'CFLAGS', " -mmacosx-version-min=#{MACOS_VERSION}"
ENV.remove 'CXXFLAGS', " -mmacosx-version-min=#{MACOS_VERSION}" So that we correctly support 10.6 and 10.8 also. |
Note that links to upstream bugs ought to appear in comments in the source, since this serves as documentation. |
==> Build Environment |
@axpence ??? |
I read through it, sorry, I just saw the line that said "please don't paste from the console log.." |
@adamv I added the source comment about the upstream ticket. @axpence Ok, no problem. I see that the debug output did not list all the currently open valgrind issues, so it led you here. Please have a look at the issue #13042 and post a link to a gist of your output of If you want to try out my commit here (which I'd appreciate, since it's always good to get feedback, capture mistakes early on, or get confirmation that it works), please first install git by To switch back to your main (clean) homebrew do |
-v failed without your commit, here is my gist: I tried doing brew install git, but I got a similar error: Also I tried to checkout your file by doing brew checkout -b valgrind_13548 and i got the following error: I just learned what homebrew is a few days ago. Guess I'm a n00b. :) |
He's probably asleep by now. He meant The fact that you get a failure installing git is sign there are some global problems. We'll try to help you fix those. You should read the Wiki Bug Fixing Checklist when you get a chance. Open a new issue for your git install and post what the wiki asks for. Thanks. |
Hello, |
brew doctor gist: https://gist.github.com/3180639 still lost :( tear thanks for all your help friends. On Wed, Jul 25, 2012 at 11:51 AM, Samuel John <
|
@axpence you should definitely try to move those offending (unbrewed) libs away (copy them). Software may easily pick up these during linking. Do you have a clue which software put them there? Perhaps you have installed some standalone compiler or whatever? |
As if all this trouble would not be enough, I found that valgrind does not want to be installed on 10.8. |
Still no progress for me. Best of luck On Thu, Jul 26, 2012 at 2:04 AM, Samuel John <
|
This patch works for me, on 10.7 with XCode 4.4 (4F250). |
Patch fixes the issues for me too (10.7 / XCode 4.4) |
def patches | ||
# For Xcode-only systems, we have to patch hard-coded paths, use xcrun and | ||
# add missing CFLAGS. See: https://bugs.kde.org/show_bug.cgi?id=295084 | ||
DATA unless MacOS.clt_installed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now MacOS::CLT.installed?
@jacknagel updated according to your review. As said before, on 10.8, valgrind's configure tells:
but that is upstream and we have to wait for a new version. |
I will open a new PR on top of #14119. |
Patch needed to build on Xcode-only systems. The patch is not applied if the CLT are installed.
Fixes #13042.
UPDATE: Valgrind does not (yet) support Mountain Lion 10.8.