update valgrind to 3.8.0

[rizzatti]

Updates valgrind to version 0.3.8 released on 10/10/2012.

[rizzatti]

@samueljohn I was trying to install valgrind and came across #13548. In your last comment, you mentioned we had to wait for upstream, so I checked their website... and they released today :)

Unfortunately, their release notes mention:
"There is initial support for MacOSX 10.8, but it is not usable for serious work at present."

Anyway, I got the CLT installed, and tweaking the CFLAGS was enough to make it install on my system (10.8 - bzero issue persisted without it even on this new release).

Samuel, would you mind checking wether your patch to xcode-only still applies for this release?

[samueljohn]

@zehrizzatti Thanks for the information. I'll check that.

[2bits]

@zehrizzatti Let's use sha1 rather than md5. It's the default now with all Formula. Thanks.

[caius]

This PR built for me on 10.8 with command line tools installed fwiw. (Using brew install https://raw.github.com/zehrizzatti/homebrew/e9ead1c2830a533bfc8f113f24fd5ffe08bc854d/Library/Formula/valgrind.rb).

Running it however, gives a fatal error. The release notes for 3.8.0 do say that 10.8 support is largely unusable at this time. Sadly.

$ valgrind 
--79720:0:main     Root stack 0x238D80000 to 0x238E84000, a local 0x238E81FB0
--79720:0:main     Valgrind: FATAL: Initial stack switched failed.
--79720:0:main        Cannot continue.  Sorry.

[samueljohn]

released on 10/10/2012.
You have secret future releases, @zehrizzatti? :-)

@adamv, @zehrizzatti we have to get both, this and my pull request together but I have to update the git diff anyway, so you can pull this one in here first and I rework my PR later. @zehrizzatti I think @adamv would love to see a comment and a note in the commit message about why we remove the one flag. Something like "avoid __bzero when building against OS X 10.8 sdk".

[2bits]

Any way to add a devel block or a head for 3.8?

[samueljohn]

@2bits I am not sure but I think valgrind 3.8 is stable on Mac OS X 10.7, so no need for --devel or am I missing something?

On OS X 10.8, we have no option but to use valgrind 3.8, because 3.7 refuses to build. And wait for a proper upstream release.

[telemachus]

Just fyi, I was able to build valgrind 3.8.0 running successfully on 10.8. I have the old vanilla gcc-4.2 installed (I used @caius's instructions, but it's also available from homebrew/dupes.) Assuming you have that version of gcc, then adding --use-gcc with this formula did the trick for me. This might also help #13609.

It seems to run ok, though Valgrind's release notes say it's still pretty raw.

[2bits]

I was just thinking that a HEAD would let people test out any recent changes affecting OSX before the release happens.

[samueljohn]

@2bits that's a good idea. I got you wrong. Yes, then --HEAD would be cool.

Btw. I ported my patch to compile valgrind on xcode-only systems to this pull request. It builds.

[rizzatti]

I'm sorry I couldn't attend this before. I'll get to it today.

[samueljohn]

@zehrizzatti cool. Please ping me if your request has been pulled. Then I can open a new PR with my patch on top for Xcode-only systems.

[rizzatti]

@adamv how does it look?

[adamv]

Needs to be squashed to a single commit for review.

[jacknagel]

Further, adding HEAD should come as a separate pull request; I suspect it is not as simple as just adding the head field. The configure script probably needs to be bootstrapped.

[rizzatti]

@adamv I squashed and resubmitted on #14323.
@jacknagel You were right. I had to change it to run autogen.sh. Their svn was down yesterday.

Closing this issue.

[samueljohn]

You have closed this, @zehrizzatti? It think @jacknagel was trying to say that the HEAD thing should be done in a new separate pull request, not that this one here is obsolete.

[rizzatti]

@samueljohn It's in #14323.

[samueljohn]

I see.