MUI improvements + search bar + navbar activation #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors
amiraliemami
force-pushed
the
mui-improvements
branch
from
588de4e to
e004d4d
Compare
amiraliemami
changed the title
sidravi1
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Love it. Nice work @amiraliemami :)
Please merge when ready.
amiraliemami
added a commit
that referenced
this pull request
Mar 21, 2024
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]>
lickem22
pushed a commit
that referenced
this pull request
Mar 22, 2024
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * Mui admin app auth (#134) * sort results by content_id * Auth and access level * fixes from review * HOTFIX: Layout import missing from "ProtectedComponent.tsx" * MUI improvements + search bar + navbar activation (#131) * MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]> * Replace old admin app with new MUI admin app (#136) * temp - remove old `src` * temp - replace/remove files * move logo png to inside admin app * Add condition for catching missing content_id * TEMP FIX: Disable missingSuspenseWithCSRBailout error. See Jira ticket 424 for details. --------- Co-authored-by: Sid Ravinutala <[email protected]>
lickem22
pushed a commit
that referenced
this pull request
Mar 22, 2024
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * Mui admin app auth (#134) * sort results by content_id * Auth and access level * fixes from review * HOTFIX: Layout import missing from "ProtectedComponent.tsx" * MUI improvements + search bar + navbar activation (#131) * MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]> * Replace old admin app with new MUI admin app (#136) * temp - remove old `src` * temp - replace/remove files * move logo png to inside admin app * Add condition for catching missing content_id * TEMP FIX: Disable missingSuspenseWithCSRBailout error. See Jira ticket 424 for details. --------- Co-authored-by: Sid Ravinutala <[email protected]>
lickem22
pushed a commit
that referenced
this pull request
Mar 22, 2024
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]>
lickem22
pushed a commit
that referenced
this pull request
Mar 22, 2024
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * Mui admin app auth (#134) * sort results by content_id * Auth and access level * fixes from review * HOTFIX: Layout import missing from "ProtectedComponent.tsx" * MUI improvements + search bar + navbar activation (#131) * MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]> * Replace old admin app with new MUI admin app (#136) * temp - remove old `src` * temp - replace/remove files * move logo png to inside admin app * Add condition for catching missing content_id * TEMP FIX: Disable missingSuspenseWithCSRBailout error. See Jira ticket 424 for details. --------- Co-authored-by: Sid Ravinutala <[email protected]>
lickem22
pushed a commit
that referenced
this pull request
Mar 22, 2024
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]>
lickem22
pushed a commit
that referenced
this pull request
Mar 22, 2024
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * Mui admin app auth (#134) * sort results by content_id * Auth and access level * fixes from review * HOTFIX: Layout import missing from "ProtectedComponent.tsx" * MUI improvements + search bar + navbar activation (#131) * MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]> * Replace old admin app with new MUI admin app (#136) * temp - remove old `src` * temp - replace/remove files * move logo png to inside admin app * Add condition for catching missing content_id * TEMP FIX: Disable missingSuspenseWithCSRBailout error. See Jira ticket 424 for details. --------- Co-authored-by: Sid Ravinutala <[email protected]>
lickem22
pushed a commit
that referenced
this pull request
Mar 22, 2024
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * Mui admin app auth (#134) * sort results by content_id * Auth and access level * fixes from review * HOTFIX: Layout import missing from "ProtectedComponent.tsx" * MUI improvements + search bar + navbar activation (#131) * MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]> * Replace old admin app with new MUI admin app (#136) * temp - remove old `src` * temp - replace/remove files * move logo png to inside admin app * Add condition for catching missing content_id * TEMP FIX: Disable missingSuspenseWithCSRBailout error. See Jira ticket 424 for details. --------- Co-authored-by: Sid Ravinutala <[email protected]>
suzinyou
pushed a commit
that referenced
this pull request
Apr 8, 2024
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * Mui admin app auth (#134) * sort results by content_id * Auth and access level * fixes from review * HOTFIX: Layout import missing from "ProtectedComponent.tsx" * MUI improvements + search bar + navbar activation (#131) * MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]> * Replace old admin app with new MUI admin app (#136) * temp - remove old `src` * temp - replace/remove files * move logo png to inside admin app * Add condition for catching missing content_id * TEMP FIX: Disable missingSuspenseWithCSRBailout error. See Jira ticket 424 for details. --------- Co-authored-by: Sid Ravinutala <[email protected]>
lickem22
pushed a commit
that referenced
this pull request
Apr 11, 2024
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @sidravi1
Estimate: 30mins
Ticket
Fixes: 415 Search bar, 416 Nav bar
Description, Motivation and Context
Goal
Changes
How has this been tested?
Same as #130
Checklist
Fill with
xfor completed. Delete any lines that are not relevant