-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve and delete multilingual content #140
Merged
lickem22
merged 10 commits into
feature-multilingual
from
multilingual/retrieve-content
Mar 29, 2024
Merged
Retrieve and delete multilingual content #140
lickem22
merged 10 commits into
feature-multilingual
from
multilingual/retrieve-content
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lickem22
commented
Mar 28, 2024
amiraliemami
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice code! Left some comments + two quick cleanup commits.
lickem22
added a commit
that referenced
this pull request
Mar 29, 2024
* List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * format code and remove extra space above add button * Improve language filter aesthetics and resizing behaviour * Quick cleanup --------- Co-authored-by: amir_emami <[email protected]>
lickem22
added a commit
that referenced
this pull request
Apr 4, 2024
* List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * edit contents * Retrieve and delete multilingual content (#140) * List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * format code and remove extra space above add button * Improve language filter aesthetics and resizing behaviour * Quick cleanup --------- Co-authored-by: amir_emami <[email protected]> * Cleanup * Frontend changes * Add default language * Remove deactivated language for edit * Fix font bug * Remove emotion/server * Fix typos * Remove package.json --------- Co-authored-by: amir_emami <[email protected]>
suzinyou
added a commit
that referenced
this pull request
Apr 9, 2024
* List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * edit contents * Retrieve and delete multilingual content (#140) * List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * format code and remove extra space above add button * Improve language filter aesthetics and resizing behaviour * Quick cleanup --------- Co-authored-by: amir_emami <[email protected]> * Cleanup * Frontend changes * Add default language * Remove deactivated language for edit * Fix font bug * Add delete contents * Code refactor to add and delete contents * Return to landing page when all languages versions are deleted * Remove emotion/server * delete package-lock.json * remove unused imports * Cleanup * Fix bugs * Add requested frontend changes * Fix text getting blank * Update content title and texts fields * add new line at end of package * Fix duplicated issue --------- Co-authored-by: amir_emami <[email protected]> Co-authored-by: Suzin You <[email protected]>
lickem22
added a commit
that referenced
this pull request
Apr 11, 2024
* List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * edit contents * Retrieve and delete multilingual content (#140) * List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * format code and remove extra space above add button * Improve language filter aesthetics and resizing behaviour * Quick cleanup --------- Co-authored-by: amir_emami <[email protected]> * Cleanup * Frontend changes * Add default language * Remove deactivated language for edit * Fix font bug * Add delete contents * Code refactor to add and delete contents * Return to landing page when all languages versions are deleted * Remove emotion/server * delete package-lock.json * remove unused imports * Add tests * Clean up * Fix frontend bug * fix frontend bugs * Update admin_app/package.json Co-authored-by: Suzin You <[email protected]> --------- Co-authored-by: amir_emami <[email protected]> Co-authored-by: Suzin You <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:@amirali
Estimate: 1h
Ticket
Fixes:AAQ-429
Description, Motivation and Context
Goal
The goal of this PR is to be able to retrieve and delete multilingual contents
Changes
On the backend side:
On the frontend side:
How has this been tested?
The contents have been added manually in different language to test displaying and deleting them.
Checklist
Fill with
x
for completed. Delete any lines that are not relevant