[AAQ-456] Add tests and final cleanups #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * format code and remove extra space above add button * Improve language filter aesthetics and resizing behaviour * Quick cleanup --------- Co-authored-by: amir_emami <[email protected]>
lickem22
commented
Apr 10, 2024
admin_app/package.json
Outdated
| @@ -28,4 +28,4 @@ | |||
| "prettier-plugin-organize-imports": "^3.2.4", | |||
| "typescript": "^5" | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Can you please fix that again on your side please @suzinyou
|
It's weird that unittests GA didn't run! |
|
Oh weird. It ran, but on the merge commit, and it's not getting associated with this PR 🤔 |
suzinyou
approved these changes
Apr 10, 2024
admin_app/package.json
Outdated
| @@ -28,4 +28,4 @@ | |||
| "prettier-plugin-organize-imports": "^3.2.4", | |||
| "typescript": "^5" | |||
| } | |||
| } | |||
| } | |||
| @@ -314,6 +315,7 @@ const CardsGrid = ({ | |||
| return apiCalls.deleteContent(content_id, null, token!); | |||
| }} | |||
| deleteLanguageVersion={handleDeleteLanguageVersion} | |||
| setRefreshKey={setRefreshKey} | |||
There was a problem hiding this comment.
It refreshes the content after deleting contents
Co-authored-by: Suzin You <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @suzinyou
Estimate: 1h
Ticket
Fixes: AAQ-456
Description
Goal
The goal of this PR is to update the tests with multilingual support and do the final cleanup/ tests to the frontend to make sure the first changes work seamlessly.
Changes
The following changes have been made on the front end:
The following changes have been made to backend:
How has this been tested?
This has been tested by running test and making sure it is working fine. This is the final feature PR. I suggest testing by making sure everything works as it should. If an issue is noticed we can decide whether to fix right away or raise the ticket depending on how critical it is and how easy it is to fix.
Checklist
Fill with
xfor completed. Delete any lines that are not relevant