Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added base_frame_id param to the rs_launch.py file #3313

Open
wants to merge 1 commit into
base: ros2-development
Choose a base branch
from

Conversation

FarStryke21
Copy link

Updates with reference to Issue #3312 .

The PR aims to expose the base_frame_id param which was missing in the rs_launch.py file. This allows the user to modify the default base_frame_id from link to something of the user's choice when using the launch file.

Following the specified guidelines, I have executed the pr_check.sh script, and no errors were reported!

@sysrsbuild
Copy link

Can one of the admins verify this patch?

@Nir-Az Nir-Az requested a review from Copilot March 6, 2025 17:55

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds a new configurable parameter, base_frame_id, to the rs_launch.py file to enable users to customize the default root frame in the sensor transform tree.

  • Adds the base_frame_id parameter with a default value of 'link'.
  • Updates the launch file to expose the parameter for user configuration.

Reviewed Changes

File Description
realsense2_camera/launch/rs_launch.py Added a new base_frame_id parameter to the launch file

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

realsense2_camera/launch/rs_launch.py:93

  • Please consider adding tests to verify the behavior of the new base_frame_id parameter to ensure that custom configuration works as expected.
{'name': 'base_frame_id',                'default': 'link', 'description': 'Root frame of the sensors transform tree'},
@Nir-Az Nir-Az requested a review from Gilaadb March 9, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants