irgen: Disable fn entry safepoints #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe use a NamedTuple or Dict you conditionally append the new parameter to, and splat that when calling the CodegenParams ctor, just to avoid some duplication. But LGTM otherwise. |
jpsamaroo
force-pushed
the
jps/no-entry-safepoints
branch
from
f473c87 to
d8e725d
Compare
|
Can we also tag a release to fix crashing CIs? |
vchuravy
reviewed
Nov 1, 2022
| track_allocations = false, | ||
| code_coverage = false, | ||
| prefer_specsig = true, | ||
| gnu_pubnames = false, | ||
| debug_info_kind = Cint(debug_info_kind), | ||
| lookup = Base.unsafe_convert(Ptr{Nothing}, lookup_cb)) | ||
| @static if VERSION >= v"1.9.0-DEV.1660" | ||
| cgparams = merge(cgparams, (;safepoint_on_entry = false)) |
There was a problem hiding this comment.
Nit, this is not high-priority. But the CPU users like Enzyme would actually want these to be emitted. So it needs to be job-dependent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364