Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interface: Make entry safepoint emission controllable #368

Merged
merged 2 commits into from
Dec 3, 2022

Conversation

jpsamaroo
Copy link
Member

@jpsamaroo jpsamaroo commented Nov 1, 2022

@jpsamaroo jpsamaroo force-pushed the jps/entry-safepoints-optional branch from e30a241 to fda68ba Compare December 2, 2022 21:41
@jpsamaroo jpsamaroo marked this pull request as ready for review December 2, 2022 21:41
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 85.70% // Head: 66.17% // Decreases project coverage by -19.53% ⚠️

Coverage data is based on head (fda68ba) compared to base (14ef9ee).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #368       +/-   ##
===========================================
- Coverage   85.70%   66.17%   -19.54%     
===========================================
  Files          24       24               
  Lines        2813     2785       -28     
===========================================
- Hits         2411     1843      -568     
- Misses        402      942      +540     
Impacted Files Coverage Δ
src/jlgen.jl 73.89% <ø> (-9.03%) ⬇️
src/interface.jl 83.33% <100.00%> (-3.80%) ⬇️
src/cache.jl 0.00% <0.00%> (-100.00%) ⬇️
src/metal.jl 0.00% <0.00%> (-87.96%) ⬇️
src/reflection.jl 37.79% <0.00%> (-40.07%) ⬇️
src/execution.jl 60.00% <0.00%> (-40.00%) ⬇️
src/ptx.jl 72.03% <0.00%> (-21.19%) ⬇️
src/irgen.jl 89.43% <0.00%> (-5.85%) ⬇️
src/debug.jl 88.88% <0.00%> (-5.56%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jpsamaroo jpsamaroo merged commit ca1f5ec into master Dec 3, 2022
@jpsamaroo jpsamaroo deleted the jps/entry-safepoints-optional branch December 3, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants