Replace FunctionSpec with methodinstance #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
==========================================
- Coverage 80.07% 78.64% -1.44%
==========================================
Files 24 24
Lines 2901 2903 +2
==========================================
- Hits 2323 2283 -40
- Misses 578 620 +42
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
maleadt
force-pushed
the
tb/functionspec
branch
3 times, most recently
from
34a5ff6 to
3022dc1
Compare
maleadt
force-pushed
the
tb/functionspec
branch
from
3022dc1 to
1a2f444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
kernelandnamekwargs gone,FunctionSpecwas becoming useless, so cut it out and replace it with Julia'sMethodInstance, as suggested by @vtjnash & @vchuravy.@jpsamaroo This is obviously breaking, but should just require changing
FunctionSpectomethodinstance. In addition, I'm removingemit_juliasince that function only served to look-up the method instance, but in a follow-up PR I'm going to change things so that you will be able to just callGPUCompiler.compileand won't need to call into any specificemit_function again.