Make it possible for downstream packages to use the compile entrypoint
#418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
==========================================
- Coverage 79.88% 79.85% -0.04%
==========================================
Files 24 24
Lines 2904 2904
==========================================
- Hits 2320 2319 -1
- Misses 584 585 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
maleadt
force-pushed
the
tb/functionspec
branch
4 times, most recently
from
3022dc1 to
1a2f444
Compare
maleadt
force-pushed
the
tb/compile_entrypoint
branch
from
c7a891e to
dcc257e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, packages like CUDA.jl were using the
emit_functions directly because they needed access to more intermediate forms of compilation results. That's a pity though because those methods are more unstable, e.g.,emit_juliagetting removed in #417.In this PR, I'm making it so that more stuff is returned when calling the main compilation driver's entrypoint,
GPUCompiler.compile. That should make it possible to avoid calling into anyemit_function, hopefully reducing breakage in the future.As part of this PR, I'm slightly simplifying the compilation hook design such that we don't need to check for it explicitly from the compilation cache.
cc @jpsamaroo