fix up and optimize Core.Compiler.method_table(::GPUCompiler)
#426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/method_table
branch
from
9a48c41 to
d0d9e13
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 86.78% 80.13% -6.66%
==========================================
Files 24 24
Lines 2928 2904 -24
==========================================
- Hits 2541 2327 -214
- Misses 387 577 +190
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Isn't the EDIT: Oh, I see the |
maleadt
force-pushed
the
avi/method_table
branch
from
d0d9e13 to
dacac8f
Compare
- restrict `mt` argument type to `Core.MethodTable` since `mt::Nothing` is not supported when using overlay method table view. - use `CachedMethodTable` if available to speed up method look up for heavy compilation workload with the duplicated method call.
aviatesk
force-pushed
the
avi/method_table
branch
from
dacac8f to
c523b3b
Compare
|
Yeah, now the argument type is divided by version. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mtargument type toCore.MethodTablesincemt::Nothingis not supported when using overlay method table view.CachedMethodTableif available to speed up method look up for heavy compilation workload with the duplicated method call.