Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use CachedMethodTable when available. #434

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Apr 19, 2023

Fixes #433; regressed in #426

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -3.77 ⚠️

Comparison is base (7a45af6) 87.14% compared to head (3291ce3) 83.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   87.14%   83.38%   -3.77%     
==========================================
  Files          24       24              
  Lines        2941     2943       +2     
==========================================
- Hits         2563     2454     -109     
- Misses        378      489     +111     
Impacted Files Coverage Δ
src/jlgen.jl 83.43% <50.00%> (-0.52%) ⬇️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit e54a20d into master Apr 19, 2023
@maleadt maleadt deleted the tb/conditional_cachedmethodtable branch April 19, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to precompile
1 participant