Tag Celeste v0.3.0 [https://github.com/jeff-regier/Celeste.jl] #8627
Conversation
| Distributions | ||
| FITSIO 0.8.4 | ||
| DiffBase 0.0.3 | ||
| ForwardDiff 0.3.4 0.5 |
There was a problem hiding this comment.
should this upper bound apply to past tags too? Pkg could choose to downgrade Celeste in order to upgrade ForwardDiff, unless past versions also have upper bounds
There was a problem hiding this comment.
Hi Tony, I think the past tags are ok without it. There is no 0.5 of ForwardDiff even, so we're probably overly cautious here.
There was a problem hiding this comment.
The best thing to do, in that case, is not to put any upper bound.
There was a problem hiding this comment.
@jrevels Do we need the upper bound?
There was a problem hiding this comment.
Since Celeste reaches under the API and uses Duals directly, and Dual is getting overhauled in ForwardDiff v0.5.0, it's almost certainly the case that ForwardDiff v0.5.0 will break Celeste until Celeste updates to support it. So I think the upper bound makes sense.
There was a problem hiding this comment.
@tkelman Is it OK to merge this PR as it is?
There was a problem hiding this comment.
now that there is a ForwardDiff 0.5.0, Pkg might downgrade Celeste to 0.2.1 in order to upgrade to it
No description provided.