Skip to content
This repository was archived by the owner on Aug 12, 2022. It is now read-only.

Tag Celeste v0.3.0 [https://github.com/jeff-regier/Celeste.jl] #8627

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Tag Celeste v0.3.0 [https://github.com/jeff-regier/Celeste.jl] #8627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Celeste/versions/0.3.0/requires
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
julia 0.6-
Compat 0.18.0
DataFrames
DataStructures 0.5.2
Distributions
FITSIO 0.8.4
DiffBase 0.0.3
ForwardDiff 0.3.4 0.5
Copy link
Contributor

@tkelman tkelman Mar 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this upper bound apply to past tags too? Pkg could choose to downgrade Celeste in order to upgrade ForwardDiff, unless past versions also have upper bounds

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tony, I think the past tags are ok without it. There is no 0.5 of ForwardDiff even, so we're probably overly cautious here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best thing to do, in that case, is not to put any upper bound.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrevels Do we need the upper bound?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Celeste reaches under the API and uses Duals directly, and Dual is getting overhauled in ForwardDiff v0.5.0, it's almost certainly the case that ForwardDiff v0.5.0 will break Celeste until Celeste updates to support it. So I think the upper bound makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkelman Is it OK to merge this PR as it is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, sorry for the delay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that there is a ForwardDiff 0.5.0, Pkg might downgrade Celeste to 0.2.1 in order to upgrade to it

ReverseDiff 0.1.1 0.2
JLD 0.6.0
Optim 0.7.4
StaticArrays 0.1.4
WCS 0.1.3
1 change: 1 addition & 0 deletions Celeste/versions/0.3.0/sha1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1d88b038aad438d17afa2f3e1e164a211d20eee3