Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shaw Imperial layout #592

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Add Shaw Imperial layout #592

merged 3 commits into from
Mar 22, 2024

Conversation

la-ninpre
Copy link
Contributor

I see that there are no options for typing in shavian on android besides the keyman app. It is okay, but somewhat slow and it's not great switching back and forth between keyboard apps all the time. After I learned that one can add a custom layout to Unexpected keyboard, I immediately thought about finally unifying all my layouts in one app, so i don't have to switch all the time.

Hope it will be useful for somebody.

And thanks for this great project!

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wrote some suggestions but I would merge once you say it's ready!

<?xml version="1.0" encoding="utf-8"?>
<!-- Shaw Imperial layout for shavian alphabet, see https://www.shavian.info/keyboards/ -->
<keyboard name="Shaw Imperial" script="shavian">
<row>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 rows is a lot and corners are underutilized.
Any way of removing one by moving some characters to the corners of other keys ?
The "Shaw QWERTY" layout manages to have only 3 rows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree, that four rows make it rather tall, but I don't know if it is okay to move a whole row to corners of adjacent row. Shavian just has more letters than Latin. I think this change would make it a different layout... I'll test to see if I can come up with something that works well.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matching the official layout is also nice! That was just a suggestion, 4 rows is fine if it's the layout that you would use. Same for the alternating shift, choose what you'd prefer using.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I came up with something that works okay. I'm thinking this: will it be okay if I add both versions? So it would be like "Shaw Imperial" and "Shaw Imperial (Compact)".

I could add Shaw QWERTY too, btw.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout selector is not ergonomic enough to handle too many layouts so I don't accept small variations and layouts without users.
But feel free to post any number of layout to https://github.com/Julow/Unexpected-Keyboard-layouts, which have a chance to be included in the app when the settings improve.

@Julow
Copy link
Owner

Julow commented Mar 16, 2024

Please use it for a while and then confirm when it's ready for merging.

@la-ninpre
Copy link
Contributor Author

I tested a few different options and for me the current one is the most comfortable to type with. I mean, the four-row version without staggering. You can merge it, if you have no other things to add.

@la-ninpre la-ninpre requested a review from Julow March 22, 2024 21:18
Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, let's merge!

Of course, feel free to make more modifications to the layout in the future.

@Julow Julow merged commit 7c32860 into Julow:master Mar 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants