Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shaw Imperial layout #592

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Add Shaw Imperial layout #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee6a758
Add Shaw Imperial layout
la-ninpre Mar 16, 2024
8b4d4b3
Shaw Imperial: Remove row shifting
la-ninpre Mar 16, 2024
ab1352b
Shaw Imperial: Move punctuation to the right to match other layouts
la-ninpre Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions check_layout.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ Layout doesn't define some important keys, missing: f11_placeholder, f12_placeho
Layout includes some ASCII punctuation but not all, missing: `
Layout doesn't define some important keys, missing: f11_placeholder, f12_placeholder
2 warnings
# shaw_imperial_en
0 warnings
# urdu_phonetic_ur
Duplicate keys:
Layout includes some ASCII punctuation but not all, missing: <, >, ?, `, |, ~
Expand Down
3 changes: 3 additions & 0 deletions res/values/layouts.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
<item>latn_qwertz_fr_ch</item>
<item>latn_qwertz_hu</item>
<item>latn_qwertz_sk</item>
<item>shaw_imperial_en</item>
<item>urdu_phonetic_ur</item>
<item>custom</item>
</string-array>
Expand Down Expand Up @@ -104,6 +105,7 @@
<item>QWERTZ (Swiss French)</item>
<item>QWERTZ (Magyar)</item>
<item>QWERTZ (Slovak)</item>
<item>Shaw Imperial</item>
<item>Urdu Phonetic</item>
<item>@string/pref_layout_e_custom</item>
</string-array>
Expand Down Expand Up @@ -157,6 +159,7 @@
<item>@xml/latn_qwertz_fr_ch</item>
<item>@xml/latn_qwertz_hu</item>
<item>@xml/latn_qwertz_sk</item>
<item>@xml/shaw_imperial_en</item>
<item>@xml/urdu_phonetic_ur</item>
<item>-1</item>
</integer-array>
Expand Down
52 changes: 52 additions & 0 deletions srcs/layouts/shaw_imperial_en.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Shaw Imperial layout for shavian alphabet, see https://www.shavian.info/keyboards/ -->
<keyboard name="Shaw Imperial" script="shavian">
<row>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 rows is a lot and corners are underutilized.
Any way of removing one by moving some characters to the corners of other keys ?
The "Shaw QWERTY" layout manages to have only 3 rows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree, that four rows make it rather tall, but I don't know if it is okay to move a whole row to corners of adjacent row. Shavian just has more letters than Latin. I think this change would make it a different layout... I'll test to see if I can come up with something that works well.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matching the official layout is also nice! That was just a suggestion, 4 rows is fine if it's the layout that you would use. Same for the alternating shift, choose what you'd prefer using.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I came up with something that works okay. I'm thinking this: will it be okay if I add both versions? So it would be like "Shaw Imperial" and "Shaw Imperial (Compact)".

I could add Shaw QWERTY too, btw.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout selector is not ergonomic enough to handle too many layouts so I don't accept small variations and layouts without users.
But feel free to post any number of layout to https://github.com/Julow/Unexpected-Keyboard-layouts, which have a chance to be included in the app when the settings improve.

<key key0="𐑶" key2="1" key4="esc"/>
<key key0="𐑬" key1="~" key2="2" key3="\@"/>
<key key0="𐑫" key1="!" key2="3" key3="\#"/>
<key key0="𐑜" key2="4" key3="$"/>
<key key0="𐑖" key1="𐑠" key2="5" key3="%"/>
<key key0="𐑗" key2="6" key3="^"/>
<key key0="𐑙" key2="7" key3="&amp;"/>
<key key0="𐑘" key2="8" key3="*"/>
<key key0="𐑡" key2="9" key3="(" key4=")"/>
<key key0="𐑔" key2="0" key3="f11_placeholder" key4="f12_placeholder"/>
</row>
<row>
<key key0="𐑭" key1="tab" key2="𐑸" key3="`"/>
<key key0="𐑷" key2="𐑹"/>
<key key0="𐑵" key2="𐑿"/>
<key key0="𐑱" key2="𐑺"/>
<key key0="𐑳" key2="𐑻"/>
<key key0="𐑓" key2="-" key3="_"/>
<key key0="𐑞" key2="=" key3="+"/>
<key key0="𐑤" key4="}" key3="{"/>
<key key0="𐑥" key3="[" key4="]"/>
<key key0="𐑣" key2="|" key3="\\"/>
</row>
<row>
<key key0="𐑪"/>
<key key0="𐑨"/>
<key key0="𐑦" key1="𐑾" key2="𐑽"/>
<key key0="𐑩" key2="𐑼"/>
<key key0="𐑧"/>
<key key0="𐑐"/>
<key key0="𐑯"/>
<key key0="𐑑"/>
<key key0="𐑮"/>
<key key0="𐑕"/>
</row>
<row>
<key key0="𐑲"/>
<key key0="𐑴"/>
<key key0="𐑰"/>
<key key0="𐑚"/>
<key key0="𐑝" key2="&lt;" key3="."/>
<key key0="𐑟" key2="&gt;" key3=","/>
<key key0="𐑒" key2="\?" key3="/"/>
<key key0="𐑢" key2=":" key3=";"/>
<key key0="𐑛" key2="&quot;" key3="'"/>
<key key0="backspace" key2="delete"/>
</row>
</keyboard>