Move artifact publishing from JCenter to Maven Central

[emarc-m]

This PR addresses #79 and #60.

Changes:

• Move artifact publishing from JCenter to Maven Central (Based on PR Enable uploading to Maven Central #80)
• Added CHANGELOG.md file
• Added RELEASING.md guide for Keepsafe employees (Based from https://github.com/KeepSafe/dexcount-gradle-plugin/blob/master/RELEASING.md)

I published version 1.4.2 in https://repo1.maven.org/maven2/com/getkeepsafe/relinker/relinker/ based from this PR while testing the publishing process and ensuring credentials configurations work.

I'll publish another version 1.4.3 to have everything tagged and update the README page.

Thanks to:

• @tthiagomartinho, @benjamin-bader, @barnhill

[benjamin-bader]

Do we need to do this upgrade at the same time? Seems like it is probably unrelated to publishing?

[emarc-m]

I think so. Without updating the build tools version, the gradle-maven-publish-plugin breaks with an error:

Caused by: org.gradle.api.UnknownDomainObjectException: SoftwareComponentInternal with name 'release' not found.

Since @barnhill will be creating another PR to update the dependencies, I opted to update this to the latest that matches the stable version for Android Studio.

[benjamin-bader]

Is gradlePluginPortal() necessary here?

[emarc-m]

I'd also vote to keep this as is and address this in another PR when a new version needs to be published.

My reasoning is that since trove4j is a transitive dependency for Android Build Tools, it might be removed in the next release version for the build tools as mentioned or be moved to Maven Central as well since JCenter will shut down.

I feel the work around would potentially hide what happened to this.

I'll add a TODO comment on the repository declaration as a note for us when we publish and it breaks.

[barnhill]

Yep ... If you take it out it won't compile. Brad Barnhill, MSN, RN [email protected]

…

On Sat, Feb 27, 2021, 9:13 PM Ben Bader ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In build.gradle <#81 (comment)>: > } } allprojects { repositories { google() - jcenter() + mavenCentral() + gradlePluginPortal() Is gradlePluginPortal() necessary here? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#81 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5S2DVIUJN3BDRUWED6D7TTBGYGPANCNFSM4YKJXREA> .

[benjamin-bader]

Yep ... If you take it out it won't compile. Brad Barnhill, MSN, RN [email protected]

Ah, our old friend trove4j, only available on jcenter (and transitively via gradlePluginPortal() which mirrors jcenter). I understand that newer versions of the Android Build Tools will not have this dependency. I'm not sure that this is a long-term solution - when jcenter shuts down, it's not clear that trove4j will still be available on the plugin portal.

There's a workaround I've seen floating around the Android world, which is to redirect that dependency to a version available on Maven Central, like so:

// in build.gradle
buildscript {
  // repositories { ... }

  // dependencies { ... }

  configurations.configureEach {
    resolutionStrategy.eachDependency {
      if (requested.group == "org.jetbrains.trove4j" && requested.name == "trove4j" && requested.version == "20160824") {
        useTarget("org.jetbrains.intellij.deps:trove4j:1.0.20181211")
      }
    }
  }
}

This would let us avoid adding the extra repository, and be perhaps more stable long-term.

[barnhill]

I would vote to leave it be for now and if it stops building then resort to more exotic fixes such as this. But then again this isnt my repo. I fully expect whoever is pulling it in will have this fixed before it goes away on JCenter.

[emarc-m]

Thank you @benjamin-bader and @barnhill for taking a look at this PR.

I'll merge this in on 03/03/2021, update the README and publish version 1.4.3 on Maven Central.

Please let me know if there are any other changes needed before I merge this in. Thank you.