Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move artifact publishing from JCenter to Maven Central #81
Move artifact publishing from JCenter to Maven Central #81
Changes from 5 commits
ffc018d
ca9fb9f
9ee8ce4
144e175
ab119a4
fb965e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do this upgrade at the same time? Seems like it is probably unrelated to publishing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. Without updating the build tools version, the
gradle-maven-publish-plugin
breaks with an error:Since @barnhill will be creating another PR to update the dependencies, I opted to update this to the latest that matches the stable version for Android Studio.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
gradlePluginPortal()
necessary here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also vote to keep this as is and address this in another PR when a new version needs to be published.
My reasoning is that since
trove4j
is a transitive dependency for Android Build Tools, it might be removed in the next release version for the build tools as mentioned or be moved to Maven Central as well since JCenter will shut down.I feel the work around would potentially hide what happened to this.
I'll add a
TODO
comment on the repository declaration as a note for us when we publish and it breaks.